Load SSL cert if environment variables exist #17
Conversation
| } else { | ||
| return false; | ||
| } | ||
| })(process.env.HTTPS, process.env.SSL_KEY_PATH, process.env.SSL_CERT_PATH); |
There was a problem hiding this comment.
Curious why you're using an IIFE here. I like the way the code looks, but just curious about the decision to go this way.
There was a problem hiding this comment.
I didn't want to call the function down below. I really wanted these methods to be in react-dev-utils and then pass in the results to this method from start.js as variable name https. Maybe that is too preemptive here.
There was a problem hiding this comment.
The problem is that start.js is not the only place that this config is imported, and the other importer doesn't have the necessary context, so what's here is good.
| const host = process.env.HOST || '0.0.0.0'; | ||
| // ZEAL: ssl file loading | ||
| const sslPath = function(path) { |
There was a problem hiding this comment.
The name sslPath doesn't communicate to me what this is doing. Maybe readSslFile or something?
craineum
force-pushed
the
ssl_cert_support
branch
from
c183a8e to
19f46db
Compare
The following environment variables are inspected:
If
HTTPSis set to true andSSL_KEY_PATH&&SSL_CERT_PATHare set, we try to load the certs via webpack devServer.This was needed to get past browser non-trusted self signed certs to have a nice happy green browser experience. See more here: facebook#2759 (comment)