Skip to content

Annotate throws with FQN #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

DBX12
Copy link
Contributor

@DBX12 DBX12 commented Oct 16, 2021

The pull request as discussed on #42

Also I fixed one documentation issue, my IDE highlighted several more but for that one I was certain that it would not have any side effects.

And again, I would highly appreciate getting the hacktoberfest-accepted label :)

DBX12 added 2 commits October 16, 2021 11:17
Documentation described a `$value` parameter, function signature had `$val` as parameter name.
@DBX12 DBX12 changed the title Annotate throws with fqn Annotate throws with FQN Oct 16, 2021
@SamMousa
Copy link
Collaborator

Can we not tackle the real issue? To me the issue is not docblock but bad code generation?

@DBX12
Copy link
Contributor Author

DBX12 commented Oct 18, 2021

I think that would be something which should happen in codeception itself and not in a module, right? I've skimmed the open issues on codeception/codeception quickly and did not find anything regarding this issue. However, after checking the code, it seems like the docblock is just copy-pasted from the module. I looked at two other modules (doctrine2 and redis) and have seen that those also don't use FQNs for their @throws annotations. So fixing it in codeception might be truly the best option. I'll open an issue in the main repo and see what happens.

@SamMousa
Copy link
Collaborator

Feel free to right a PR for that!

@samdark samdark merged commit f57b558 into Codeception:master Nov 26, 2021
@samdark
Copy link
Member

samdark commented Nov 26, 2021

This one is right to be merged anyway. @DBX12 would you please link to the issue you've created?

@DBX12
Copy link
Contributor Author

DBX12 commented Nov 26, 2021

You mean the issue at codeception/codeception? The issue is here and a PR attempting to fix it is here but I'm currently stuck with a conflict in the dependencies and was requesting input from the Maintainers / other contributors as it would need a bigger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants