fix(sa): use Assert::fail so that phpstan understand code doesn't continue

Author: SamMousa

phpstan.neon

@@ -17,6 +17,9 @@ parameters:
     checkMaybeUndefinedVariables: true
     treatPhpDocTypesAsCertain: false
     ignoreErrors:
+        - identifier: return.type
+          path: tests/_support/_generated/FunctionalTesterActions.php
+          message: "# but returns mixed.$#"
         # If you want to ignore missing generics errors in the future, you can add:
         # - identifier: missingType.generics
     stubFiles:

src/Codeception/Module/Yii2.php

@@ -16,6 +16,7 @@
 use Codeception\Lib\Interfaces\MultiSession;
 use Codeception\Lib\Interfaces\PartedModule;
 use Codeception\TestInterface;
+use PHPUnit\Framework\Assert;
 use ReflectionClass;
 use RuntimeException;
 use Symfony\Component\BrowserKit\CookieJar;
@@ -647,7 +648,7 @@ public function haveRecord(string $model, $attributes = []): int|string|array
         $record = \Yii::createObject($model);
         $record->setAttributes($attributes, false);
         if (! $record->save(false)) {
-            $this->fail("Record $model was not saved: " . \yii\helpers\Json::encode($record->errors));
+            Assert::fail("Record $model was not saved: " . \yii\helpers\Json::encode($record->errors));
         }
         return $record->getPrimaryKey();
     }
@@ -667,7 +668,7 @@ public function seeRecord(string $model, array $attributes = []): void
     {
         $record = $this->findRecord($model, $attributes);
         if (! $record) {
-            $this->fail("Couldn't find $model with " . json_encode($attributes));
+            Assert::fail("Couldn't find $model with " . json_encode($attributes));
         }
         $this->debugSection($model, json_encode($record));
     }
@@ -688,7 +689,7 @@ public function dontSeeRecord(string $model, array $attributes = []): void
         $record = $this->findRecord($model, $attributes);
         $this->debugSection($model, json_encode($record));
         if ($record) {
-            $this->fail("Unexpectedly managed to find $model with " . json_encode($attributes));
+            Assert::fail("Unexpectedly managed to find $model with " . json_encode($attributes));
         }
     }