Skip to content

Commit 820e26c

Browse files
fsologurenglunny
authored and
Loïc Dachary
committed
Improve accessibility of navigation bar and footer (go-gitea#22635)
Added ARIA navigation landmark to navigation bar and aria label for both nav bar and footer. Contributed by @forgejo. --------- Co-authored-by: Lunny Xiao <[email protected]> (cherry picked from commit b0e338283459f0af2bdf66a568517fb4c1aeaafb)
1 parent 42e27a4 commit 820e26c

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

options/locale/locale_en-US.ini

+6
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ never = Never
106106

107107
rss_feed = RSS Feed
108108

109+
[aria]
110+
navbar = Navigation Bar
111+
footer = Footer
112+
footer.software = About Software
113+
footer.links = Links
114+
109115
[filter]
110116
string.asc = A - Z
111117
string.desc = Z - A

templates/base/footer_content.tmpl

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<footer>
1+
<footer role="group" aria-label="{{.locale.Tr "aria.footer"}}">
22
<div class="ui container">
3-
<div class="ui left">
3+
<div class="ui left" role="contentinfo" aria-label="{{.locale.Tr "aria.footer.software"}}">
44
<a target="_blank" rel="noopener noreferrer" href="https://gitea.io">{{.locale.Tr "powered_by" "Gitea"}}</a>
55
{{if (or .ShowFooterVersion .PageIsAdmin)}}
66
{{.locale.Tr "version"}}:
@@ -15,7 +15,7 @@
1515
{{.locale.Tr "template"}}{{if .TemplateName}} {{.TemplateName}}{{end}}: <strong>{{call .TemplateLoadTimes}}</strong>
1616
{{end}}
1717
</div>
18-
<div class="ui right links">
18+
<div class="ui right links" role="group" aria-label="{{.locale.Tr "aria.footer.links"}}">
1919
{{if .ShowFooterBranding}}
2020
<a target="_blank" rel="noopener noreferrer" href="https://github.com/go-gitea/gitea">{{svg "octicon-mark-github"}}<span class="sr-only">GitHub</span></a>
2121
{{end}}

templates/base/head_navbar.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="ui container" id="navbar">
1+
<div class="ui container" id="navbar" role="navigation" aria-label="{{.locale.Tr "aria.navbar"}}">
22
{{$notificationUnreadCount := 0}}
33
{{if .IsSigned}}
44
{{if .NotificationUnreadCount}}{{$notificationUnreadCount = call .NotificationUnreadCount}}{{end}}

0 commit comments

Comments
 (0)