✨ Move selected lines up and down

[austincondiff]

Description

Users should be able to move lines up or down with ⇧ ⌘ [ and ] or by going to Editor > Move Line Up and Move Line Down.

Screenshots

[Bogdan-Belogurov]

@austincondiff Hello! Do you mind if I take this?

[0xWDG]

@austincondiff Hello! Do you mind if I take this?

I have assigned you :)

[Bogdan-Belogurov]

@0xWDG
Hello!
I've made the first prototype

Details

normal.mov

And I noticed a few problems:

1. If I select a line from the zero position, then in the editSelections method, the selection range includes that line, even if the selection is not actually visible in the UI. Is that the way it's meant to be?

Details

issue.mov

2. As I see from Xcode, during line up/down actions, the selected lines understand their scope and automatically add/remove additional indents. Can you please show me where to look to implement similar logic? 🙏🏿

[austincondiff]

First of all, great work so far! Maybe if the selection ends with a newline character, we exclude it. Would that work?

[Bogdan-Belogurov]

@austincondiff
Thanks! I'm not sure about the newline character because it allows you to draw the whole line in the UI, am I right?

From my perspective, it would be better to handle this case in the getHighlightedLines-> textLineForOffset method. What do you think?