Route: Allow specifying a routing metric value #2051
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2051/1/input |
|
retest this please |
|
LGTM. I'll leave this open for a week or 2 for others to review and test it. |
|
Apologies, have just spotted a bug. I'll revise. (correction: I will force-push later today when I have access to my hardware key). |
The Route resource did not previously support setting a routing metric (i.e. a priority which the newly created route will carry). This is a common requirement, and is already supported in agents such as IPsrcaddr and IPaddr2.
tim-seoss
force-pushed
the
heartbeat-route-add-metric
branch
from
8003fde to
36eb27a
Compare
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2051/3/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Route resource did not previously support setting a routing metric (i.e. a priority which the newly created route will carry). This is a common requirement, and is already supported in agents such as IPsrcaddr and IPaddr2.