Skip to content

Commit 157369c

Browse files
authored
Merge pull request #351 from Enmk/fix_version
Fixed version-related hiccups
2 parents db374b8 + 21793b8 commit 157369c

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

clickhouse/version.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,3 @@
1212
+ CLICKHOUSE_CPP_VERSION_MINOR * 100 * 100 \
1313
+ CLICKHOUSE_CPP_VERSION_PATCH * 100 \
1414
+ CLICKHOUSE_CPP_VERSION_BUILD
15-
16-
#define CLICKHOUSE_CPP_VERSION_STRING #CLICKHOUSE_CPP_VERSION_MAJOR "." #CLICKHOUSE_CPP_VERSION_MINOR "." #CLICKHOUSE_CPP_VERSION_PATCH

cmake/version.cmake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@ function (regex_extract_matching_groups INPUT REGEX_STR)
1818
endforeach ()
1919
endfunction ()
2020

21-
regex_extract_matching_groups("ttest" "FAILED TO SERCH" RESULT)
2221

2322
function(clickhouse_cpp_get_version)
2423
# Extract all components of the version from the clickhouse/version.h
2524

26-
file(READ ${CMAKE_SOURCE_DIR}/clickhouse/version.h VERSION_FILE_DATA)
25+
file(READ ${CMAKE_CURRENT_SOURCE_DIR}/clickhouse/version.h VERSION_FILE_DATA)
2726

2827
foreach (VERSION_COMPONENT
2928
IN ITEMS

ut/client_ut.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,6 @@ TEST_P(ClientCase, Version) {
107107
EXPECT_EQ(CLICKHOUSE_CPP_VERSION_PATCH, version.patch);
108108
EXPECT_EQ(CLICKHOUSE_CPP_VERSION_BUILD, version.build);
109109
EXPECT_EQ(CLICKHOUSE_CPP_VERSION_PATCH, version.patch);
110-
111-
// EXPECT_EQ(CLICKHOUSE_CPP_VERSION, versionNumber(version.major, version.minor, version.patch, version.build));
112110
}
113111

114112
TEST_P(ClientCase, Array) {

0 commit comments

Comments
 (0)