Skip to content

Commit 066807c

Browse files
author
Vladimir Matveyev
committed
Ability to disable query-target/rsp-subtree/rsp-prop-include in GET request
1 parent 2967649 commit 066807c

File tree

2 files changed

+32
-18
lines changed

2 files changed

+32
-18
lines changed

src/rest/connector/libs/apic/implementation.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -238,13 +238,20 @@ def get(self, dn, query_target='self', rsp_subtree='no', \
238238
"alias '{a}'".format(d=self.device.name,
239239
a=self.alias))
240240

241-
full_url = "{f}{dn}?query-target={qt}&rsp-subtree={rs}"\
242-
"&rsp-prop-include={rpi}"\
243-
.format(f=self.url,
244-
dn=dn,
245-
qt=query_target,
246-
rs=rsp_subtree,
247-
rpi=rsp_prop_include)
241+
full_url = "{f}{dn}".format(f=self.url, dn=dn.lstrip('/'))
242+
243+
if query_target:
244+
full_url += "?query-target={qt}"\
245+
.format(qt=query_target)
246+
247+
if rsp_subtree:
248+
full_url += "&rsp-subtree={rs}"\
249+
.format(rs=rsp_subtree)
250+
251+
if rsp_prop_include:
252+
full_url += "&rsp-prop-include={rpi}"\
253+
.format(rpi=rsp_prop_include)
254+
248255
if query_target_filter:
249256
full_url += "&query-target-filter={qtf}"\
250257
.format(qtf=query_target_filter)
@@ -313,7 +320,7 @@ def post(self, dn, payload, xml_payload=False,
313320
"alias '{a}'".format(d=self.device.name,
314321
a=self.alias))
315322
# Deal with the dn
316-
full_url = '{f}{dn}'.format(f=self.url, dn=dn)
323+
full_url = '{f}{dn}'.format(f=self.url, dn=dn.lstrip('/'))
317324

318325
log.info("Sending POST command to '{d}':"\
319326
"\nDN: {furl}\nPayload:{p}".format(d=self.device.name,
@@ -375,7 +382,7 @@ def delete(self, dn, expected_status_code=requests.codes.ok, timeout=30):
375382
a=self.alias))
376383

377384
# Deal with the dn
378-
full_url = '{f}{dn}'.format(f=self.url, dn=dn)
385+
full_url = '{f}{dn}'.format(f=self.url, dn=dn.lstrip('/'))
379386

380387
log.info("Sending DELETE command to '{d}':"\
381388
"\nDN: {furl}".format(d=self.device.name, furl=full_url))

src/rest/connector/libs/nxos/aci/implementation.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -226,13 +226,20 @@ def get(self, dn, query_target='self', rsp_subtree='no', \
226226
"alias '{a}'".format(d=self.device.name,
227227
a=self.alias))
228228

229-
full_url = "{f}{dn}?query-target={qt}&rsp-subtree={rs}"\
230-
"&rsp-prop-include={rpi}"\
231-
.format(f=self.url,
232-
dn=dn,
233-
qt=query_target,
234-
rs=rsp_subtree,
235-
rpi=rsp_prop_include)
229+
full_url = "{f}{dn}".format(f=self.url, dn=dn.lstrip('/'))
230+
231+
if query_target:
232+
full_url += "?query-target={qt}"\
233+
.format(qt=query_target)
234+
235+
if rsp_subtree:
236+
full_url += "&rsp-subtree={rs}"\
237+
.format(rs=rsp_subtree)
238+
239+
if rsp_prop_include:
240+
full_url += "&rsp-prop-include={rpi}"\
241+
.format(rpi=rsp_prop_include)
242+
236243
if query_target_filter:
237244
full_url += "&query-target-filter={qtf}"\
238245
.format(qtf=query_target_filter)
@@ -293,7 +300,7 @@ def post(self, dn, payload, expected_status_code=requests.codes.ok,
293300
"alias '{a}'".format(d=self.device.name,
294301
a=self.alias))
295302
# Deal with the dn
296-
full_url = '{f}{dn}'.format(f=self.url, dn=dn)
303+
full_url = '{f}{dn}'.format(f=self.url, dn=dn.lstrip('/'))
297304

298305
log.info("Sending POST command to '{d}':"\
299306
"\nDN: {furl}\nPayload:{p}".format(d=self.device.name,
@@ -338,7 +345,7 @@ def delete(self, dn, expected_status_code=requests.codes.ok, timeout=30):
338345
a=self.alias))
339346

340347
# Deal with the dn
341-
full_url = '{f}{dn}'.format(f=self.url, dn=dn)
348+
full_url = '{f}{dn}'.format(f=self.url, dn=dn.lstrip('/'))
342349

343350
log.info("Sending DELETE command to '{d}':"\
344351
"\nDN: {furl}".format(d=self.device.name, furl=full_url))

0 commit comments

Comments
 (0)