Skip to content

Commit eb8461a

Browse files
ChristosTjourdain
authored andcommitted
chore(js): Allow triggering release on external artifact static_viewer.html
Previously, when a new version of static_viewer.html is released on the master of vtk-js we couldn't trigger a release because we do not commit this file but rather grab it during release. This commit adds the hash of the latest version in a file and a hash check that runs during release but does not trigger a failure on a mismatch but rather a warning. So now if static_viewer.html is updated on vtk-js: - If we do not care `.fetch_externals.sh` will just emit a warning - If we **do** care we update .static_viewer.sha256 and trigger a new release on trame-vtk even if no other `trame-vtk` change happened during last release.
1 parent 6a57e2f commit eb8461a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.fetch_externals.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,8 @@ set -e
55
mkdir -p ./trame_vtk/modules/common/serve
66
curl https://unpkg.com/[email protected] -Lo ./trame_vtk/modules/common/serve/trame-vtk.js
77
# echo 19e7c20470b952cc7b38f1434180b5ec ./trame_vtk/modules/common/serve/trame-vtk.js | md5sum -c --status && echo OK
8-
curl https://kitware.github.io/vtk-js/examples/OfflineLocalView/OfflineLocalView.html -Lo ./trame_vtk/tools/static_viewer.html
8+
curl https://kitware.github.io/vtk-js/examples/OfflineLocalView/OfflineLocalView.html -Lo ./trame_vtk/tools/static_viewer.html
9+
10+
if ! sha256sum --check .static_viewer.sha256 ; then
11+
echo "Hash for static_viewer.html differs, please update .static_viewer.sha256"
12+
fi

.static_viewer.sha256

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
b757777855acdc69644186c0678fb8f15cd28614fc96454e567ee81ae57ff3be ./trame_vtk/tools/static_viewer.html

0 commit comments

Comments
 (0)