allow further texture uniforms #12558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @bkuster! ✅ We can confirm we have a CLA on file for you. |
|
A friendly reminder to @jjhembd to take a pass on this. |
jjhembd
requested changes
Apr 17, 2025
| @@ -483,7 +483,7 @@ function loadFramebufferSource(texture, source) { | |||
| * Load texel data from an Image into a texture. | |||
| * | |||
| * @param {Texture} texture The texture to which texel values will be loaded. | |||
| * @param {ImageData|HTMLImageElement|HTMLCanvasElement|HTMLVideoElement} source The source for texel values to be loaded into the texture. | |||
| * @param {ImageData|HTMLImageElement|HTMLCanvasElement|HTMLVideoElement|OffscreenCanvas|ImageBitmap} source The source for texel values to be loaded into the texture. | |||
There was a problem hiding this comment.
This update to the type should also apply to the functions that call loadImageSource.
- The doc for
Texture.copyFromshould be a straightforward update. - The
Textureconstructor itself is messier, but I thinkTexture.ConstructorOptions.sourcecould have the same doc asoptions.sourcefromTexture.copyFrom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The number of image data types available to
Materialsshould be upgraded with some more data types:In my usecase, I already have an ImageBitmap created in a worker and would like to avoid having to draw it onto a canvas to then pass it to the Texture, when I could just pass it directly.
Testing plan
Added tests to MetarialSpec.js for both use cases.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change