If a style has a val of 0, it still gets styled #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| val = el.get('val') | ||
| if val is None: | ||
| return True | ||
| return val.lower() not in ['false', '0'] |
There was a problem hiding this comment.
I would like to see this as a constant. DISABLED_STYLE_VALUES or some such.
Also, why are you doing the is None check?
I would have expected '' to be in your list of falsy values and just:
val = el.get('val', '').lower()
return val not in DISABLED_STYLE_VALUES
added 2 commits
July 2, 2013 14:53
Conflicts: CHANGELOG
|
Looks good other than the refactor |
jlward
added a commit
that referenced
this pull request
Jul 2, 2013
If a style has a val of 0, it still gets styled
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If a style has a val of 0, it still gets styled
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
If a style has a val of 0, it still gets styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.