Better feature flag types and add forks route flag

Author: jamescdavis

app/components/osf-navbar/component.ts

@@ -54,7 +54,6 @@ export default class OsfNavbar extends Component {
     indexRoute: string = 'dashboard';
     showNavLinks: boolean = false;
 
-    // @ts-ignore - we can be sure we have institutions route
     @computed(`features.${camelize(config.featureFlags.routes.institutions)}`)
     get osfApps(this: OsfNavbar) {
         return osfServices.filter(each => !each.flag || this.features.isEnabled(each.flag));

app/router.ts

@@ -3,6 +3,12 @@ import { inject as service } from '@ember/service';
 import config from 'ember-get-config';
 import { Blocker } from 'ember-osf-web/services/ready';
 
+const {
+    featureFlags: {
+        routes,
+    },
+} = config as { featureFlags: { routes: { [index: string]: string } } }; // eslint-disable-line no-use-before-define
+
 const Router = EmberRouter.extend({
     currentUser: service('current-user'),
     statusMessages: service('status-messages'),
@@ -13,7 +19,7 @@ const Router = EmberRouter.extend({
     rootURL: config.rootURL,
 
     async willTransition(oldInfo: any, newInfo: any, transition: { targetName: string }) {
-        const flag = config.featureFlags.routes[transition.targetName];
+        const flag = routes[transition.targetName];
 
         if (flag) {
             const enabled = await this.get('currentUser').getWaffle(flag);

config/environment.d.ts

@@ -118,7 +118,13 @@ declare const config: {
         noteworthyNode: string;
     };
     featureFlags: {
-        routes: { [index: string]: string | undefined };
+        routes: {
+            support: string;
+            dashboard: string;
+            home: string;
+            institutions: string;
+            'guid-node.forks': string;
+        };
     };
     gReCaptcha: {
         siteKey: string;

config/environment.js

@@ -181,6 +181,7 @@ module.exports = function(environment) {
                 dashboard: 'ember_home_page',
                 home: 'ember_home_page',
                 institutions: 'ember_institutional_landing_page',
+                'guid-node.forks': 'ember_project_forks_page',
             },
         },
         gReCaptcha: {