Add a ctor overload in Range. Adjust ctor parameter order in Diagnostic.

Author: CXuesong

DemoLanguageServer/DiagnosticProvider.cs

@@ -26,7 +26,7 @@ public ICollection<Diagnostic> LintDocument(TextDocument document, int maxNumber
             {
                 diag.Add(new Diagnostic(DiagnosticSeverity.Hint,
                     new Range(new Position(0, 0), document.PositionAt(content?.Length ?? 0)),
-                    "DLS0001", "Empty document. Try typing something, such as \".net core\".", "DLS"));
+                    "DLS", "DLS0001", "Empty document. Try typing something, such as \".net core\"."));
                 return diag;
             }
             foreach (var kw in Keywords)
@@ -43,13 +43,11 @@ public ICollection<Diagnostic> LintDocument(TextDocument document, int maxNumber
                     if (inputKw != kw)
                     {
                         diag.Add(new Diagnostic(DiagnosticSeverity.Warning,
-                            new Range(document.PositionAt(pos), document.PositionAt(separatorPos)),
-                            "DLS1001", $"\"{inputKw}\" should be \"{kw}\".", "DLS"));
+                            new Range(document.PositionAt(pos), document.PositionAt(separatorPos)), "DLS", "DLS1001", $"\"{inputKw}\" should be \"{kw}\"."));
                         if (diag.Count >= maxNumberOfProblems)
                         {
                             diag.Add(new Diagnostic(DiagnosticSeverity.Information,
-                                new Range(document.PositionAt(pos), document.PositionAt(separatorPos)),
-                                "DLS2001", "Too many messages, exiting…", "DLS"));
+                                new Range(document.PositionAt(pos), document.PositionAt(separatorPos)), "DLS", "DLS2001", "Too many messages, exiting…"));
                             return diag;
                         }
                     }

LanguageServer.VsCode/Contracts/Diagnostic.cs

@@ -47,17 +47,17 @@ public Diagnostic()
         {
         }
 
-        public Diagnostic(DiagnosticSeverity severity, Range range, string code, string message) : this(severity, range, code, message, null)
+        public Diagnostic(DiagnosticSeverity severity, Range range, string source, string message) : this(severity, range, source, null, message)
         {
         }
 
-        public Diagnostic(DiagnosticSeverity severity, Range range, string code, string message, string source)
+        public Diagnostic(DiagnosticSeverity severity, Range range, string source, string code, string message)
         {
             Severity = severity;
             Range = range;
+            Source = source;
             Code = code;
             Message = message;
-            Source = source;
         }
 
         /// <summary>

LanguageServer.VsCode/Contracts/Location.cs

@@ -57,6 +57,12 @@ public Range(Position start, Position end)
             End = end;
         }
 
+        public Range(int startLine, int startCharacter, int endLine, int endCharacter)
+        {
+            Start = new Position(startLine, startCharacter);
+            End = new Position(endLine, endCharacter);
+        }
+
         public Position Start { get; set; }
 
         public Position End { get; set; }