Skip to content

Commit 223763b

Browse files
Titozzzadrienharnay
authored andcommitted
fix(falsy resources): Falsy resources handling (#68)
1 parent 6956bf4 commit 223763b

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

__tests__/internals/selectors/generateResourceSelectors.test.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ const {
2222

2323
const emptyDenormalizer = () => [];
2424
const {
25-
resource: {
26-
getResourceById: getResourceByIdWithEmptyDenormalizer,
27-
},
25+
resource: { getResourceById: getResourceByIdWithEmptyDenormalizer },
2826
} = generateResourceSelectors('fruits', emptyDenormalizer);
2927

3028
const STARTED_AT = moment();
@@ -152,10 +150,22 @@ const RECEIVED_FULL_RESOURCE_ID_STATE = {
152150
fruits: [2],
153151
},
154152
},
153+
'eat:https://api.co/fruits/3': {
154+
resourceName: 'fruits',
155+
resourceId: 3,
156+
startedAt: STARTED_AT,
157+
endedAt: ENDED_AT,
158+
hasSucceeded: true,
159+
hasFailed: false,
160+
payloadIds: {
161+
fruits: [3],
162+
},
163+
},
155164
},
156165
resources: {
157166
fruits: {
158167
2: 'cherry',
168+
3: false,
159169
},
160170
},
161171
},
@@ -310,6 +320,10 @@ describe('generateResourceSelectors', () => {
310320
'received empty resource id state',
311321
emptyCase(RECEIVED_EMPTY_RESOURCE_ID_STATE, 2),
312322
);
323+
test(
324+
'received full resource id state, falsy',
325+
fullCase(RECEIVED_FULL_RESOURCE_ID_STATE, 3),
326+
);
313327
test(
314328
'received full resource id state',
315329
fullCase(RECEIVED_FULL_RESOURCE_ID_STATE, 2),

src/internals/selectors/generateResourceSelectors.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ const getResourceById = (
8181
const resource
8282
= state.resources
8383
&& state.resources[resourceName]
84-
&& state.resources[resourceName][resourceId]
84+
&& state.resources[resourceName][resourceId] !== undefined
8585
? state.resources[resourceName][resourceId]
8686
: EMPTY_RESOURCE_ID;
8787

0 commit comments

Comments
 (0)