Skip to content

added example of recommendation engine (favorite t-shirts) #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2018

Conversation

LegendOfGIT
Copy link

@LegendOfGIT LegendOfGIT commented Apr 16, 2018

My favorite color is chrome

Description

An expample of a recommendation engine, build with brain,js

Motivation and Context

Show other devs how to use brain.js in the real world

How Has This Been Tested?

Manually ;)

Types of changes

  • added a folder in examples with example code for recommendation engine

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

@robertleeplummerjr robertleeplummerjr changed the base branch from master to develop April 17, 2018 01:23
Copy link
Contributor

@freddyC freddyC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically I would suggest "Let put this in a sister repo to keep brain.js small/clutter free" but I think I am changing my attitude a bit.

Also this is a super simple example, well done, and starts sets up a way to add additional simple examples.

giphy

The only thing I can think of to improve this (off the top of my head) would be to add a readme to this example's directory with a brief explanation on this example, then link that examples page on the main readme.

I would prefer the readme bit, but if you don't want to add it in I am not against this being merged as is.

@robertleeplummerjr robertleeplummerjr merged commit 0834619 into BrainJS:develop Apr 20, 2018
@robertleeplummerjr
Copy link
Contributor

good work guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants