Changes based on style and lint checks. (final_code_quality_5) #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeedogs
force-pushed
the
final_code_quality_5
branch
2 times, most recently
from
155ddd9 to
a93254f
Compare
|
|
coffeedogs
force-pushed
the
final_code_quality_5
branch
from
a93254f to
afd7603
Compare
PeterSurda
reviewed
Oct 12, 2018
src/network/asyncore_pollchoose.py
Outdated
| @@ -75,13 +78,15 @@ | |||
| except (ImportError, AttributeError): | |||
| WSAECONNRESET = ECONNRESET | |||
| try: | |||
| from errno import WSAEADDRINUSE | |||
| # side-effects on Windows or cruft? | |||
There was a problem hiding this comment.
Yea this is workaround for some Windows crap, it uses winsock which is kind of similar to unix' socket, but it can have its own error numbers, and these aren't defined when running python on other OSes. Maybe there is a nicer workaround but for the time being let's keep it as it is.
There was a problem hiding this comment.
Updated in next commit...
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
reviewed
Oct 12, 2018
PeterSurda
previously requested changes
Oct 12, 2018
coffeedogs
force-pushed
the
final_code_quality_5
branch
2 times, most recently
from
5a74284 to
e6d2cd5
Compare
g1itch
reviewed
Oct 15, 2018
coffeedogs
force-pushed
the
final_code_quality_5
branch
2 times, most recently
from
baee386 to
fbf9361
Compare
coffeedogs
force-pushed
the
final_code_quality_5
branch
2 times, most recently
from
6793d88 to
7cf1ce5
Compare
PeterSurda
reviewed
Oct 27, 2018
PeterSurda
reviewed
Oct 27, 2018
PeterSurda
reviewed
Oct 27, 2018
PeterSurda
reviewed
Oct 28, 2018
PeterSurda
approved these changes
Oct 28, 2018
coffeedogs
force-pushed
the
final_code_quality_5
branch
2 times, most recently
from
50bee6d to
e8c76da
Compare
coffeedogs
force-pushed
the
final_code_quality_5
branch
from
e8c76da to
0bceeca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes based on style and lint checks. (final_code_quality_5)