Resolved pylint redefined-variable-type warnings

Author: g1itch

src/bitmessageqt/__init__.py

@@ -2033,7 +2033,7 @@ def click_pushButtonSend(self):
                             # attempt register
                             if email[-14:] != "@mailchuck.com":
                                 # 12 character random email address
-                                email = ''.join(
+                                email = u''.join(
                                     random.SystemRandom().choice(
                                         string.ascii_lowercase
                                     ) for _ in range(12)
@@ -2049,78 +2049,77 @@ def click_pushButtonSend(self):
                                 " an email gateway. Sending registration"
                                 " now as {0}, please wait for the registration"
                                 " to be processed before retrying sending."
-                                ).format(email)
-                            )
+                            ).format(email))
                             return
                     status, addressVersionNumber, streamNumber, ripe = \
                         decodeAddress(toAddress)
                     if status != 'success':
                         try:
-                            toAddress = unicode(toAddress, 'utf-8', 'ignore')
+                            toAddress_value = unicode(
+                                toAddress, 'utf-8', 'ignore')
                         except:
                             logger.warning(
-                                "Failed unicode(toAddress ):",
-                                exc_info=True)
+                                "Failed unicode(toAddress ):", exc_info=True)
                         logger.error(
                             'Error: Could not decode recipient address %s: %s',
-                            toAddress, status)
+                            toAddress_value, status)
 
                         if status == 'missingbm':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: Bitmessage addresses start with"
                                 " BM-   Please check the recipient address {0}"
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'checksumfailed':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: The recipient address {0} is not"
                                 " typed or copied correctly. Please check it."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'invalidcharacters':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: The recipient address {0} contains"
                                 " invalid characters. Please check it."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'versiontoohigh':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: The version of the recipient address"
                                 " {0} is too high. Either you need to upgrade"
                                 " your Bitmessage software or your"
                                 " acquaintance is being clever."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'ripetooshort':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: Some data encoded in the recipient"
                                 " address {0} is too short. There might be"
                                 " something wrong with the software of"
                                 " your acquaintance."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'ripetoolong':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: Some data encoded in the recipient"
                                 " address {0} is too long. There might be"
                                 " something wrong with the software of"
                                 " your acquaintance."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         elif status == 'varintmalformed':
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: Some data encoded in the recipient"
                                 " address {0} is malformed. There might be"
                                 " something wrong with the software of"
                                 " your acquaintance."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                         else:
                             self.updateStatusBar(_translate(
                                 "MainWindow",
                                 "Error: Something is wrong with the"
                                 " recipient address {0}."
-                                ).format(toAddress))
+                            ).format(toAddress_value))
                     elif fromAddress == '':
                         self.updateStatusBar(_translate(
                             "MainWindow",
@@ -4313,6 +4312,8 @@ def tableWidgetInboxItemClicked(self):
         except NameError:
             message = u""
         except IndexError:
+            # _translate() often returns unicode, no redefinition here!
+            # pylint: disable=redefined-variable-type
             message = _translate(
                 "MainWindow",
                 "Error occurred: could not load message from disk."