fix a bug that provider crashes when loading azure schema (#295)

Author: ms-henglu

CHANGELOG.md

@@ -6,6 +6,7 @@ FEATURES:
 ENHANCEMENTS:
 
 BUG FIXES:
+- Fix a bug that provider crashes when loading azure schema.
 
 ## v1.6.0
 FEATURES:

internal/azure/loader.go

@@ -7,6 +7,7 @@ import (
 	"log"
 	"sort"
 	"strings"
+	"sync"
 
 	"github.com/Azure/terraform-provider-azapi/internal/azure/types"
 )
@@ -16,7 +17,11 @@ var schema *Schema
 //go:embed generated
 var StaticFiles embed.FS
 
+var mutex = &sync.Mutex{}
+
 func GetAzureSchema() *Schema {
+	mutex.Lock()
+	defer mutex.Unlock()
 	if schema == nil {
 		data, err := StaticFiles.ReadFile("generated/index.json")
 		if err != nil {

internal/provider/provider.go

@@ -6,7 +6,6 @@ import (
 	"log"
 	"os"
 	"strings"
-	"sync"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
@@ -308,10 +307,7 @@ func providerConfigure(p *schema.Provider) schema.ConfigureContextFunc {
 		}
 
 		// load schema
-		var mutex sync.Mutex
-		mutex.Lock()
 		azure.GetAzureSchema()
-		mutex.Unlock()
 		return client, nil
 	}
 }