Chain result upto compare method #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishrutshah, |
vishrutshah
commented
Aug 9, 2017
lib/validate.js
Outdated
| return openApiDiff.compare(oldSwagger, newSwagger); | ||
| return openApiDiff.compare(oldSwagger, newSwagger).then((result, err) => { | ||
| console.log(result); | ||
| }); |
vishrutshah
commented
Aug 9, 2017
lib/validate.js
Outdated
| @@ -29,5 +29,7 @@ exports.compare = function compare(oldSwagger, newSwagger, options) { | |||
| log.filepath = options.logFilepath || log.filepath; | |||
| let openApiDiff = new OpenApiDiff(options); | |||
|
|
|||
| return openApiDiff.compare(oldSwagger, newSwagger); | |||
| return openApiDiff.compare(oldSwagger, newSwagger).then((result, err) => { | |||
vishrutshah
commented
Aug 9, 2017
lib/validate.js
Outdated
| @@ -30,6 +30,10 @@ exports.compare = function compare(oldSwagger, newSwagger, options) { | |||
| let openApiDiff = new OpenApiDiff(options); | |||
|
|
|||
| return openApiDiff.compare(oldSwagger, newSwagger).then((result, err) => { | |||
| console.log(result); | |||
| if (err) { | |||
There was a problem hiding this comment.
no need for if (err) if we do catch
Address review feedback
vishrutshah
force-pushed
the
chain-result
branch
from
f14684c to
4d9c926
Compare
This reverts commit 4d9c926.
|
@veronicagg & @amarzavery I've updated PR to incorporate yesterday's feedback. Please feel free to review again as you get chance. Thanks! Here is the successfully failed CI Build: https://travis-ci.org/Azure/azure-rest-api-specs/builds/262944817?utm_source=github_status&utm_medium=notification |
amarzavery
reviewed
Aug 10, 2017
CHANGELOG.md
Outdated
| @@ -1,6 +1,10 @@ | |||
| ## 0.1.7 | |||
| Released on 2017-08-10. | |||
| - Chaining the promises upto `compare` method and gracefully existing application [#88](https://github.com/Azure/openapi-diff/issues/88) | |||
lib/validators/openApiDiff.js
Outdated
| @@ -61,11 +61,8 @@ class OpenApiDiff { | |||
|
|
|||
| return Promise.all([promise1, promise2]).then(results => { | |||
| return self.processViaOpenApiDiff(results[0], results[1]).then((result, error) => { | |||
There was a problem hiding this comment.
return Promise.all([promise1, promise2]).then(results => {
return self.processViaOpenApiDiff(results[0], results[1]); //this is already returning a promise, so need to chain a redundant `.then()` to it
};
amarzavery
approved these changes
Aug 10, 2017
|
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #88
Verification PR : Azure/azure-rest-api-specs#1520
Verification Build : https://travis-ci.org/Azure/azure-rest-api-specs/builds/262397614?utm_source=github_status&utm_medium=notification
TODO: