Removed MsSql specific error code checking, with the tradeoff of not sending HTTP 400 for trying to insert in a table with autogen'd primary key. Adjusted test framework to accommodate.

Author: seantleonard

DataGateway.Service.Tests/SqlTests/RestApiTestBase.cs

@@ -472,9 +472,8 @@ await SetupAndRunRestApiTest(
                     operationType: Operation.Upsert,
                     requestBody: requestBody,
                     exception: true,
-                    expectedErrorMessage: $"Could not perform the given mutation on entity books. " +
-                                            "Request contains value for field that is autogenerated.",
-                    expectedStatusCode: (int)HttpStatusCode.BadRequest,
+                    expectedErrorMessage: $"Could not perform the given mutation on entity books.",
+                    expectedStatusCode: (int)HttpStatusCode.InternalServerError,
                     expectedSubStatusCode: DatagatewayException.SubStatusCodes.DatabaseOperationFailed.ToString()
                 );
         }

DataGateway.Service/Resolvers/SqlMutationEngine.cs

@@ -151,22 +151,9 @@ await PerformMutationOperation(
                 Console.Error.WriteLine(ex.Message);
                 Console.Error.WriteLine(ex.StackTrace);
 
-                StringBuilder messageDetails = new($"Could not perform the given mutation on entity {context.EntityName}.");
-                int statusCode = (int)HttpStatusCode.InternalServerError;
-                SqlException sqlException = ex as SqlException;
-
-                if (sqlException != null)
-                {
-                    if (sqlException.Number == 544)
-                    {
-                        messageDetails.Append(" Request contains value for field that is autogenerated.");
-                        statusCode = (int)HttpStatusCode.BadRequest;
-                    }
-                }
-
                 throw new DatagatewayException(
-                    message: messageDetails.ToString(),
-                    statusCode: statusCode,
+                    message: $"Could not perform the given mutation on entity {context.EntityName}.",
+                    statusCode: (int)HttpStatusCode.InternalServerError,
                     subStatusCode: DatagatewayException.SubStatusCodes.DatabaseOperationFailed);
             }
             catch (Exception ex)