Fixing unintended update to GraphQL operation when updating REST methods (#1555)

## Why make this change?

- Closes #1554 
1. Creating a stored procedure entity with graphql configured for Query

Command: `dab add getbooks --source "get_books" --source.type
"stored-procedure" --permissions "anonymous:execute" --graphql.operation
"query" `
Config Json (just the entities section):

```json
 "entities": {
    "getbooks": {
  "source": {
    "object": "get_books",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "post"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }
```

2. Update the rest method to GET
Command: `dab update getbooks --rest.methods "GET"`

Config Json:
```json
"entities": {
    "getbooks": {
  "source": {
    "object": "get_books",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "mutation",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "get"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }

```
When updating the rest.methods, the graphql operation has lost its
original value of `query`. It now has the default value of `mutation`.

## What is this change?

- `ConfigGenerator.ConstructUpdatedGraphQLDetails()`: When GraphQL
operation is not updated, logic for preserving the existing configured
graphQL operation is added
- `EndToEndTests.TestUpdatingStoredProcedureWithRestMethods()`: Adds a
test case with the mentioned repro steps

## How was this tested?

- [x] Unit Tests
- [x] Manual Tests

## Sample Request(s)

- `dab add getbooks --source "getbooks" --source.type "stored-procedure"
--permissions "anonymous:execute" --graphql.operation "query"`

```json
 "entities": {
    "getbooks": {
  "source": {
    "object": "getbooks",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "post"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
  }
```
- `dab update getbooks --rest.methods "get,patch"`

```json
 "entities": {
    "getbooks": {
  "source": {
    "object": "getbooks",
    "type": "stored-procedure",
    "parameters": null,
    "key-fields": null
  },
  "graphql": {
    "enabled": true,
    "operation": "query",
    "type": {
      "singular": "getbooks",
      "plural": "getbooks"
    }
  },
  "rest": {
    "enabled": true,
    "path": null,
    "methods": [
      "get",
      "patch"
    ]
  },
  "permissions": [
    {
      "role": "anonymous",
      "actions": [
        {
          "action": "execute",
          "fields": null,
          "policy": {
            "request": null,
            "database": null
          }
        }
      ]
    }
  ],
  "mappings": null,
  "relationships": null
}
```
The `rest.methods` field is updated with the right values and the
existing value of `graphql.operation` is preserved

---------

Co-authored-by: Aaron Powell <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: abhishekkumams <[email protected]>

Author: 5 people

src/Cli.Tests/EndToEndTests.cs

@@ -484,6 +484,34 @@ public void TestUpdateEntity()
         Assert.AreEqual("Company Name", entity.Mappings["name"]);
     }
 
+    /// <summary>
+    /// Validates the updation of REST Methods for a stored procedure entity
+    /// </summary>
+    [TestMethod]
+    public Task TestUpdatingStoredProcedureWithRestMethods()
+    {
+        string[] initArgs = { "init", "-c", TEST_RUNTIME_CONFIG_FILE, "--database-type", "mssql",
+            "--host-mode", "Development", "--connection-string", "testconnectionstring", "--set-session-context", "true" };
+        Program.Execute(initArgs, _cliLogger!, _fileSystem!, _runtimeConfigLoader!);
+
+        Assert.IsTrue(_runtimeConfigLoader!.TryLoadConfig(TEST_RUNTIME_CONFIG_FILE, out RuntimeConfig? runtimeConfig));
+        Assert.IsNotNull(runtimeConfig);
+        Assert.AreEqual(0, runtimeConfig.Entities.Count()); // No entities
+
+        string[] addArgs = { "add", "MyEntity", "-c", TEST_RUNTIME_CONFIG_FILE, "--source", "s001.book", "--permissions", "anonymous:execute", "--source.type", "stored-procedure", "--source.params", "param1:123,param2:hello,param3:true", "--rest.methods", "post,put,patch", "--graphql.operation", "query" };
+        Program.Execute(addArgs, _cliLogger!, _fileSystem!, _runtimeConfigLoader!);
+
+        Assert.IsTrue(_runtimeConfigLoader!.TryLoadConfig(TEST_RUNTIME_CONFIG_FILE, out RuntimeConfig? updatedRuntimeConfig));
+        Assert.AreNotSame(runtimeConfig, updatedRuntimeConfig);
+
+        string[] updateArgs = { "update", "MyEntity", "-c", TEST_RUNTIME_CONFIG_FILE, "--rest.methods", "get" };
+        Program.Execute(updateArgs, _cliLogger!, _fileSystem!, _runtimeConfigLoader!);
+
+        Assert.IsTrue(_runtimeConfigLoader!.TryLoadConfig(TEST_RUNTIME_CONFIG_FILE, out RuntimeConfig? updatedRuntimeConfig2));
+        Assert.AreNotSame(updatedRuntimeConfig, updatedRuntimeConfig2);
+        return Verify(updatedRuntimeConfig2);
+    }
+
     /// <summary>
     /// Test to validate that the engine starts successfully when --verbose and --LogLevel
     /// options are used with the start command

src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt

@@ -0,0 +1,68 @@
+{
+  DataSource: {
+    DatabaseType: MSSQL,
+    Options: {
+      set-session-context: {
+        ValueKind: True
+      }
+    }
+  },
+  Runtime: {
+    Rest: {
+      Enabled: true,
+      Path: /api
+    },
+    GraphQL: {
+      Enabled: true,
+      Path: /graphql,
+      AllowIntrospection: true
+    },
+    Host: {
+      Cors: {
+        AllowCredentials: false
+      },
+      Authentication: {
+        Provider: StaticWebApps,
+        Jwt: {}
+      }
+    }
+  },
+  Entities: [
+    {
+      MyEntity: {
+        Source: {
+          Object: s001.book,
+          Type: stored-procedure,
+          Parameters: {
+            param1: 123,
+            param2: hello,
+            param3: true
+          }
+        },
+        GraphQL: {
+          Singular: MyEntity,
+          Plural: MyEntities,
+          Enabled: true,
+          Operation: Query
+        },
+        Rest: {
+          Methods: [
+            Get
+          ],
+          Enabled: true
+        },
+        Permissions: [
+          {
+            Role: anonymous,
+            Actions: [
+              {
+                Action: Execute,
+                Policy: {}
+              }
+            ]
+          }
+        ]
+      }
+    }
+  ]
+}

src/Cli/ConfigGenerator.cs

@@ -1094,7 +1094,7 @@ private static EntityGraphQLOptions ConstructUpdatedGraphQLDetails(Entity entity
         {
             //Updated GraphQL Type
             EntityGraphQLOptions graphQLType = (options.GraphQLType is not null) ? ConstructGraphQLTypeDetails(options.GraphQLType, null) : entity.GraphQL;
-            GraphQLOperation? graphQLOperation = null;
+            GraphQLOperation? graphQLOperation;
 
             if (!IsStoredProcedureConvertedToOtherTypes(entity, options)
                 && (IsStoredProcedure(entity) || IsStoredProcedure(options)))
@@ -1111,6 +1111,12 @@ private static EntityGraphQLOptions ConstructUpdatedGraphQLDetails(Entity entity
                         graphQLOperation = null;
                     }
                 }
+                else
+                {
+                    // When the GraphQL operation for a SP entity has not been specified in the update command,
+                    // assign the existing GraphQL operation.
+                    graphQLOperation = entity.GraphQL.Operation;
+                }
             }
             else
             {