Skip to content

Commit 498c74c

Browse files
author
Jelte Fennema
committed
Address small review comments
1 parent 2c4dc17 commit 498c74c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

DataGateway.Service/Resolvers/MsSqlQueryBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public string WrapSubqueryColumn(string column, SqlQueryStructure subquery)
3131

3232
public string Build(SqlQueryStructure structure)
3333
{
34-
string selectedColumns = String.Join(", ", structure.Columns.Select(x => $"{x.Value} AS {QuoteIdentifier(x.Key)}"));
34+
string selectedColumns = string.Join(", ", structure.Columns.Select(x => $"{x.Value} AS {QuoteIdentifier(x.Key)}"));
3535
string fromPart = structure.Table(structure.TableName, structure.TableAlias);
3636
fromPart += String.Join(
3737
"",

DataGateway.Service/Resolvers/PostgresQueryBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public string WrapSubqueryColumn(string column, SqlQueryStructure subquery)
2323

2424
public string Build(SqlQueryStructure structure)
2525
{
26-
string selectedColumns = String.Join(", ", structure.Columns.Select(x => $"{x.Value} AS {QuoteIdentifier(x.Key)}"));
26+
string selectedColumns = string.Join(", ", structure.Columns.Select(x => $"{x.Value} AS {QuoteIdentifier(x.Key)}"));
2727
string fromPart = structure.Table(structure.TableName, structure.TableAlias);
2828
fromPart += String.Join("", structure.JoinQueries.Select(x => $" LEFT OUTER JOIN LATERAL ({Build(x.Value)}) AS {QuoteIdentifier(x.Key)} ON TRUE"));
2929
string query = $"SELECT {selectedColumns} FROM {fromPart}";

DataGateway.Service/Resolvers/SqlQueryEngine.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ private static async Task<string> GetJsonStringFromDbReader(DbDataReader dbDataR
4848
// 1. https://docs.microsoft.com/en-us/sql/relational-databases/json/format-query-results-as-json-with-for-json-sql-server?view=sql-server-2017#output-of-the-for-json-clause
4949
// 2. https://stackoverflow.com/questions/54973536/for-json-path-results-in-ssms-truncated-to-2033-characters/54973676
5050
// 3. https://docs.microsoft.com/en-us/sql/relational-databases/json/use-for-json-output-in-sql-server-and-in-client-apps-sql-server?view=sql-server-2017#use-for-json-output-in-a-c-client-app
51-
if (await dbDataReader.ReadAsync())
51+
while (await dbDataReader.ReadAsync())
5252
{
5353
jsonString.Append(dbDataReader.GetString(0));
5454
}

0 commit comments

Comments
 (0)