Supports User Errors #228
Open
Supports User Errors #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deeptivaidymsft
commented
Feb 13, 2025
deeptivaidymsft
commented
- PR defines various user and system errors that can be used to provide clarification in the extension substatus
- Incorporates errors with clarification throughout CSE Linux + tests
deeptivaidymsft
requested review from
malhotrarohit,
jscalev,
norakoiralamsft and
mayankdaruka-msft
jscalev
requested changes
Feb 18, 2025
| dir, err := ioutil.TempDir("", "") | ||
| require.Nil(t, err) | ||
| dir := os.TempDir() | ||
| // require.Nil(t, err) |
There was a problem hiding this comment.
Should this be checking for a nil ewc?
| @@ -48,7 +48,7 @@ func TestWithRetries_noRetries(t *testing.T) { | |||
| sr := new(sleepRecorder) | |||
|
|
|||
| n, err := download.WithRetries(nopLog(), file, []download.Downloader{d}, sr.Sleep) | |||
| require.Nil(t, err, "should not fail") | |||
| require.Nil(t, err.Err, "should not fail") | |||
There was a problem hiding this comment.
This looks strange. If there is no error, then we shouldn't return one. Requiring one to check within the err object seems likely to cause problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.