Glusterfs #249
Glusterfs #249
Conversation
scripts/glusterfs_vol.sh
Outdated
| mkdir -p /mnt/brick1/$GLUSTERFS_VOL_NAME | ||
|
|
||
| if [ "$PSSH_NODENUM" = "0" ]; then | ||
| for host in `cat ~hpcadmin/azhpc_install_config/hostlists/$HOSTLIST` |
There was a problem hiding this comment.
config file name is hardcoded as well ad the username, it's fine right now, but this can easily be broken by using another config file name or user
There was a problem hiding this comment.
Thanks Xavier, I changed the example dir name to be glusterfs_ephemeral.
scripts/glusterfs_vol.sh
Outdated
|
|
||
| GLUSTERFS_VOL_NAME=gv0 | ||
|
|
||
| mkdir -p /mnt/brick1/$GLUSTERFS_VOL_NAME |
There was a problem hiding this comment.
/mnt/brick1 is hardcoded, can you add it as a param and default to that value ?
There was a problem hiding this comment.
Added BRICK_MOUNT_PT variable with default /mnt/brick1
scripts/glusterfs_pool.sh
Outdated
| systemctl status glusterd | ||
|
|
||
| if [ "$PSSH_NODENUM" = "0" ]; then | ||
| for host in `cat ~hpcadmin/azhpc_install_config/hostlists/$HOSTLIST` |
There was a problem hiding this comment.
username and config file name hardcoded, maybe the hostlist full path should be provided instead ? @edwardsp what do you think ?
There was a problem hiding this comment.
the scripts are run from inside the temp directory - you could just use "cat hostlists/$HOSTLIST". But, better still, you could just set the arg in the config as "$(<hostlists/glusterfs)" and then you would get it as the first arg. You would only then need to iterate as follows:
for host in $HOSTLIST; do ...
There was a problem hiding this comment.
Thanks Paul and Xavier, I made the changes you suggested, looks cleaner now.
Initial support for glusterfs in azurehpc.