-
Notifications
You must be signed in to change notification settings - Fork 67
Changed os and data disk defaults to Premium SSD #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we should be giving premium disk by default? That is an expensive option. Especially for the OS disk which would be mostly cached. It's definitely not an ARM default... (and we never had it as a default even for a fileserver...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all configurable anyway in the config. Let's keep the defaults as they were.
I think Premium_SSD's will typically deliver better performance than Standard SSD's. For Production environments/benchmarking I think Premium SSD's would be preferred. |
re-opened. |
Shall we discuss and decide as a group on this one next team meeting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's build a fully documented schema of the config file structure and values and add a link to it in all examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the os_storage_sku and storage_sku in the config files with these values too so users will know which properties to change.
My preference would be to create a separate PR updating config files explicitly including the disk type parameter. Would that be ok? |
Sure |
Changed the default OS and data disk to Premium SSD's so there are no performance surprises when an NFS server or OS disk is created with default settings.