Skip to content

Changed os and data disk defaults to Premium SSD #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

garvct
Copy link
Collaborator

@garvct garvct commented Apr 8, 2020

Changed the default OS and data disk to Premium SSD's so there are no performance surprises when an NFS server or OS disk is created with default settings.

@garvct garvct requested review from edwardsp, xpillons and hmeiland April 8, 2020 20:48
Copy link
Collaborator

@xpillons xpillons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

Copy link
Collaborator

@edwardsp edwardsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we should be giving premium disk by default? That is an expensive option. Especially for the OS disk which would be mostly cached. It's definitely not an ARM default... (and we never had it as a default even for a fileserver...)

Copy link
Collaborator

@edwardsp edwardsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all configurable anyway in the config. Let's keep the defaults as they were.

@edwardsp edwardsp closed this Apr 9, 2020
@garvct
Copy link
Collaborator Author

garvct commented Apr 9, 2020

I think Premium_SSD's will typically deliver better performance than Standard SSD's. For Production environments/benchmarking I think Premium SSD's would be preferred.
If we leave Standard SSD's as the default at minimum I would like to see it as a mandatory option in the config file, so its clear that Standard SSD's are used and not Premium SSD's.

@garvct garvct reopened this Apr 9, 2020
@garvct
Copy link
Collaborator Author

garvct commented Apr 9, 2020

re-opened.

@garvct garvct requested review from edwardsp and xpillons April 9, 2020 18:20
@edwardsp
Copy link
Collaborator

edwardsp commented Apr 9, 2020

Shall we discuss and decide as a group on this one next team meeting?

Copy link
Collaborator

@xpillons xpillons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's build a fully documented schema of the config file structure and values and add a link to it in all examples

Copy link
Collaborator

@xpillons xpillons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the os_storage_sku and storage_sku in the config files with these values too so users will know which properties to change.

@garvct
Copy link
Collaborator Author

garvct commented Apr 15, 2020

My preference would be to create a separate PR updating config files explicitly including the disk type parameter. Would that be ok?

@garvct garvct requested a review from xpillons April 15, 2020 14:37
@xpillons
Copy link
Collaborator

My preference would be to create a separate PR updating config files explicitly including the disk type parameter. Would that be ok?

Sure

@garvct garvct merged commit 593b42a into master Apr 15, 2020
@garvct garvct deleted the data_disk_defaults branch April 15, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants