make pylint dev requirement not install on < 3.8 #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
scbedd
changed the title
annatisch
approved these changes
Apr 17, 2019
Not that I'm aware of! I've got an item on the backlog to make it happen. However, for local dev, I feel that it's appropriate to be there. I'm glad you already had this, as otherwise we wouldn't even be aware that this package would run into this error. As it stands, at least we know about it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8alphaX is failing to run the tests due to the following issue
The reason
typed_astis failing right now is because 3.8alpha removedpgenheaders that the package leverages to pull out information used by pylint. (dependency path ispylint->asteroid->typed-ast)This currently only affects servicebus because servicebus has an explicit dev dependency on
pylint. If pylint was active on the repo in general, we'd end up needing to disable the 3.8 python until we come up with a way to deal with this.