Skip to content

Commit 4ddfd5c

Browse files
authored
Correct util duration variables (#36982)
1 parent 236849c commit 4ddfd5c

File tree

2 files changed

+4
-2
lines changed
  • sdk/monitor/azure-monitor-opentelemetry-exporter

2 files changed

+4
-2
lines changed

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ def _getlocale():
121121

122122
def ns_to_duration(nanoseconds: int) -> str:
123123
value = (nanoseconds + 500000) // 1000000 # duration in milliseconds
124-
value, microseconds = divmod(value, 1000)
124+
value, milliseconds = divmod(value, 1000)
125125
value, seconds = divmod(value, 60)
126126
value, minutes = divmod(value, 60)
127127
days, hours = divmod(value, 24)
128128
return "{:d}.{:02d}:{:02d}:{:02d}.{:03d}".format(
129-
days, hours, minutes, seconds, microseconds
129+
days, hours, minutes, seconds, milliseconds
130130
)
131131

132132

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ def setUp(self):
4040
def test_nanoseconds_to_duration(self):
4141
ns_to_duration = _utils.ns_to_duration
4242
self.assertEqual(ns_to_duration(0), "0.00:00:00.000")
43+
self.assertEqual(ns_to_duration(500000), "0.00:00:00.001") # Rounding
4344
self.assertEqual(ns_to_duration(1000000), "0.00:00:00.001")
45+
self.assertEqual(ns_to_duration(1500000), "0.00:00:00.002") # Rounding
4446
self.assertEqual(ns_to_duration(1000000000), "0.00:00:01.000")
4547
self.assertEqual(ns_to_duration(60 * 1000000000), "0.00:01:00.000")
4648
self.assertEqual(ns_to_duration(3600 * 1000000000), "0.01:00:00.000")

0 commit comments

Comments
 (0)