Skip to content

Commit 260a029

Browse files
authored
Renamed remaining connection string EV references (#18682)
1 parent d03c70d commit 260a029

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

sdk/communication/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ If the tests are successful, we can proceed to run the tests in LIVE mode.
2727

2828
### Live mode
2929

30-
Because in LIVE mode we are hitting an actual resource, we must set the appropriate environment variable to make sure the code tests against the resource we want. Set up an env variable called `AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING` and set it to the connection string of the resource you want to test against.
30+
Because in LIVE mode we are hitting an actual resource, we must set the appropriate environment variable to make sure the code tests against the resource we want. Set up an env variable called `COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING` (just needed for SMS and Phone Numbers SDKs) and set it to the connection string of the resource you want to test against.
3131

3232
Depending on which package you are testing, it may need special environment variables to test succesfully. The names of these variables can be found inside each test file in the `setUp()` function. Make sure to set these variables before running the tests themselves. You may need to restart your development environment after creating or updating these environment variables.
3333

sdk/communication/azure-communication-chat/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ to create a resource, then set some Environment Variables
544544

545545
```bash
546546
set AZURE_COMMUNICATION_SERVICE_ENDPOINT="https://<RESOURCE_NAME>.communcationservices.azure.com"
547-
set AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING="<connection string of your Communication service>"
547+
set COMMUNICATION_SAMPLES_CONNECTION_STRING="<connection string of your Communication service>"
548548

549549
pip install azure-communication-identity
550550

sdk/communication/azure-communication-identity/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ import os
3232
from azure.communication.identity import CommunicationIdentityClient
3333
from azure.identity import DefaultAzureCredential
3434

35-
connection_str = os.getenv('AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING')
36-
endpoint = os.getenv('AZURE_COMMUNICATION_SERVICE_ENDPOINT')
35+
connection_str = "endpoint=ENDPOINT;accessKey=KEY"
36+
endpoint = "https://<RESOURCE_NAME>.communication.azure.com"
3737

3838
# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
3939
# AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.

sdk/communication/azure-communication-phonenumbers/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ import os
2323
from azure.communication.phonenumbers import PhoneNumbersClient
2424
from azure.identity import DefaultAzureCredential
2525

26-
endpoint = os.getenv('AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING')
27-
26+
endpoint = "https://<RESOURCE_NAME>.communication.azure.com"
2827
# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have your
2928
# AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.
3029
phone_numbers_client = PhoneNumbersClient(endpoint, DefaultAzureCredential())
@@ -38,7 +37,7 @@ Connection string authentication is also available for Phone Numbers Client.
3837
import os
3938
from azure.communication.phonenumbers import PhoneNumbersClient
4039

41-
connection_str = os.getenv('AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING')
40+
connection_str = "endpoint=ENDPOINT;accessKey=KEY"
4241
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)
4342
```
4443

sdk/communication/azure-communication-sms/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,12 @@ Alternatively, you can also use Active Directory authentication using DefaultAzu
4646
from azure.communication.sms import SmsClient
4747
from azure.identity import DefaultAzureCredential
4848

49-
connection_string = os.getenv('AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING')
49+
connection_str = "endpoint=ENDPOINT;accessKey=KEY"
5050
sms_client = SmsClient.from_connection_string(connection_string)
51+
5152
# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
5253
# AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.
53-
endpoint = os.getenv('AZURE_COMMUNICATION_SERVICE_ENDPOINT')
54+
endpoint = "https://<RESOURCE_NAME>.communication.azure.com"
5455
sms_client = SmsClient(endpoint, DefaultAzureCredential())
5556
```
5657

0 commit comments

Comments
 (0)