fixed resource type validation in ParseResourceType and correlated tests (#25517)

* omit whitespace parts in splitStringAndOmitEmpty; fixed tests for ParseResourceType

* updated changelog

Author: whisk

sdk/azcore/CHANGELOG.md

@@ -11,6 +11,7 @@
 ### Bugs Fixed
 
 * Fixed potential panic when decoding base64 strings.
+* Fixed an issue in resource identifier parsing which prevented it from returning an error for malformed resource IDs.
 
 ### Other Changes
 

sdk/azcore/arm/internal/resource/resource_identifier.go

@@ -217,6 +217,7 @@ func appendNext(parent *ResourceID, parts []string, id string) (*ResourceID, err
 func splitStringAndOmitEmpty(v, sep string) []string {
 	r := make([]string, 0)
 	for _, s := range strings.Split(v, sep) {
+		s = strings.TrimSpace(s)
 		if len(s) == 0 {
 			continue
 		}

sdk/azcore/arm/internal/resource/resource_identifier_test.go

@@ -291,6 +291,8 @@ func TestParseResourceIdentifier(t *testing.T) {
 		"/providers":                                                 nil,
 		"":                                                           nil,
 		" ":                                                          nil,
+		"//":                                                         nil,
+		"/ /":                                                        nil,
 		"asdfghj":                                                    nil,
 		"123456":                                                     nil,
 		"!@#$%^&*/":                                                  nil,

sdk/azcore/arm/internal/resource/resource_type_test.go

@@ -61,14 +61,20 @@ func TestParseResourceType(t *testing.T) {
 		"/": {
 			err: true,
 		},
+		"//": {
+			err: true,
+		},
+		"/ /": {
+			err: true,
+		},
 	}
 	for input, expected := range resourceTypeData {
 		resourceType, err := ParseResourceType(input)
 		if err != nil && !expected.err {
 			t.Fatalf("unexpected error: %+v", err)
 		}
-		if expected.err {
-			continue
+		if err == nil && expected.err {
+			t.Fatalf("expected error for %q, but got result %v", input, resourceType)
 		}
 		if resourceType.Namespace != expected.namespace {
 			t.Fatalf("expecting %s, but got %s", expected.namespace, resourceType.Namespace)