Make arguments -MinScaleUnits and -MaxScaleUnits optional in Set-AzExpressRouteGateway (#13428)

* make scaling unit optional

* make scaling unit optional

make scaling unit optional

Co-authored-by: Yeming Liu <[email protected]>

Author: nimaller

src/Network/Network/ChangeLog.md

@@ -37,6 +37,7 @@
 	- Added parameter `-CoverageLevel`
 	- Added parameter `-Scope`
 * Updated `New-AzNetworkWatcherConnectionMonitorProtocolConfigurationObject` cmdlet with new parameter `-DestinationPortBehavior`
+* Made arguments `-MinScaleUnits` and `-MaxScaleUnits` optional in `Set-AzExpressRouteGateway` 
 * Added new cmdlets to support Mutual Authentication and SSL Profiles on Application Gateway
     - `Get-AzApplicationGatewayClientAuthConfiguration`
     - `New-AzApplicationGatewayClientAuthConfiguration`

src/Network/Network/Cortex/ExpressRouteGateway/SetAzureRmExpressRouteGatewayCommand.cs

@@ -71,12 +71,12 @@ public class UpdateAzureRmExpressRouteGatewayCommand : ExpressRouteGatewayBaseCm
         public string ResourceId { get; set; }
 
         [Parameter(
-            Mandatory = true,
+            Mandatory = false,
             HelpMessage = "Min for the scale units for this ExpressRouteGateway.")]
         public uint MinScaleUnits { get; set; }
 
         [Parameter(
-            Mandatory = true,
+            Mandatory = false,
             HelpMessage = "Max for the scale units for this ExpressRouteGateway.")]
         public uint MaxScaleUnits { get; set; }
 
@@ -116,13 +116,16 @@ public override void Execute()
                 throw new PSArgumentException(Properties.Resources.ExpressRouteGatewayNotFound);
             }
 
-            if (this.MinScaleUnits > this.MaxScaleUnits)
+            if (this.MinScaleUnits > 0 && this.MaxScaleUnits > 0)
             {
-                throw new PSArgumentException(string.Format(Properties.Resources.InvalidAutoScaleConfiguration, this.MinScaleUnits, this.MaxScaleUnits));
-            }
+                if (this.MinScaleUnits > this.MaxScaleUnits)
+                {
+                    throw new PSArgumentException(string.Format(Properties.Resources.InvalidAutoScaleConfiguration, this.MinScaleUnits, this.MaxScaleUnits));
+                }
 
-            existingExpressRouteGateway.AutoScaleConfiguration.Bounds.Min = Convert.ToInt32(this.MinScaleUnits);
-            existingExpressRouteGateway.AutoScaleConfiguration.Bounds.Max = Convert.ToInt32(this.MaxScaleUnits);
+                existingExpressRouteGateway.AutoScaleConfiguration.Bounds.Min = Convert.ToInt32(this.MinScaleUnits);
+                existingExpressRouteGateway.AutoScaleConfiguration.Bounds.Max = Convert.ToInt32(this.MaxScaleUnits);
+            }
 
             ConfirmAction(
                     Properties.Resources.SettingResourceMessage,

src/Network/Network/help/Set-AzExpressRouteGateway.md

@@ -14,28 +14,28 @@ Updates a Scalable ExpressRoute Gateway.
 
 ### ByExpressRouteGatewayName (Default)
 ```
-Set-AzExpressRouteGateway -ResourceGroupName <String> -Name <String> -MinScaleUnits <UInt32>
- -MaxScaleUnits <UInt32> [-Tag <Hashtable>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
+Set-AzExpressRouteGateway -ResourceGroupName <String> -Name <String> [-MinScaleUnits <UInt32>]
+ [-MaxScaleUnits <UInt32>] [-Tag <Hashtable>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
  [-Confirm] [<CommonParameters>]
 ```
 
 ### ByExpressRouteGatewayObject
 ```
-Set-AzExpressRouteGateway -InputObject <PSExpressRouteGateway> -MinScaleUnits <UInt32> -MaxScaleUnits <UInt32>
+Set-AzExpressRouteGateway -InputObject <PSExpressRouteGateway> [-MinScaleUnits <UInt32>] [-MaxScaleUnits <UInt32>]
  [-Tag <Hashtable>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
  [<CommonParameters>]
 ```
 
 ### ByExpressRouteGatewayResourceId
 ```
-Set-AzExpressRouteGateway -ResourceId <String> -MinScaleUnits <UInt32> -MaxScaleUnits <UInt32>
+Set-AzExpressRouteGateway -ResourceId <String> [-MinScaleUnits <UInt32>] [-MaxScaleUnits <UInt32>]
  [-Tag <Hashtable>] [-AsJob] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
  [<CommonParameters>]
 ```
 
 ## DESCRIPTION
 
-Set-AzExpressRouteGateway updates the scale units for the ExpressRouteGateway
+The **Set-AzExpressRouteGateway** cmdlet enables you to update the scale units for an existing ExpressRouteGateway or update the resource tags.
 
 ## EXAMPLES