Merge pull request #8411 from dealaus/SqlFixNullRef

[SQL] Fix null ref when not logged into Azure account for all sql cmdlets

Author: cormacpayne

src/Sql/Sql/AdvancedThreatProtection/Cmdlet/SqlManagedInstanceAdvancedDataSecurityCmdletBase.cs

@@ -74,7 +74,7 @@ protected override ManagedInstanceAdvancedDataSecurityPolicyModel GetEntity()
         /// </summary>
         /// <param name="subscription">The AzureSubscription in which the current execution is performed</param>
         /// <returns>An initialized and ready to use ModelAdapter object</returns>
-        protected override SqlAdvancedThreatProtectionAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override SqlAdvancedThreatProtectionAdapter InitModelAdapter()
         {
             return new SqlAdvancedThreatProtectionAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/AdvancedThreatProtection/Cmdlet/SqlServerAdvancedThreatProtectionCmdletBase.cs

@@ -75,9 +75,8 @@ protected override ServerAdvancedThreatProtectionPolicyModel GetEntity()
         /// <summary>
         /// Creation and initialization of the ModelAdapter object
         /// </summary>
-        /// <param name="subscription">The AzureSubscription in which the current execution is performed</param>
         /// <returns>An initialized and ready to use ModelAdapter object</returns>
-        protected override SqlAdvancedThreatProtectionAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override SqlAdvancedThreatProtectionAdapter InitModelAdapter()
         {
             return new SqlAdvancedThreatProtectionAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/AdvancedThreatProtection/Services/SqlAdvancedThreatProtectionAdapter.cs

@@ -48,7 +48,7 @@ public class SqlAdvancedThreatProtectionAdapter
         public SqlAdvancedThreatProtectionAdapter(IAzureContext context)
         {
             Context = context;
-            Subscription = context.Subscription;
+            Subscription = context?.Subscription;
             SqlThreatDetectionAdapter = new SqlThreatDetectionAdapter(Context);
         }
 

src/Sql/Sql/Advisor/Cmdlet/AzureSqlDatabaseAdvisorCmdletBase.cs

@@ -51,9 +51,8 @@ public abstract class AzureSqlDatabaseAdvisorCmdletBase : AzureSqlCmdletBase<IEn
         /// <summary>
         /// Initializes the model adapter
         /// </summary>
-        /// <param name="subscription">The subscription the cmdlets are operation under</param>
         /// <returns>The advisor adapter</returns>
-        protected override AzureSqlDatabaseAdvisorAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override AzureSqlDatabaseAdvisorAdapter InitModelAdapter()
         {
             return new AzureSqlDatabaseAdvisorAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/Advisor/Cmdlet/AzureSqlElasticPoolAdvisorCmdletBase.cs

@@ -51,9 +51,8 @@ public abstract class AzureSqlElasticPoolAdvisorCmdletBase : AzureSqlCmdletBase<
         /// <summary>
         /// Initializes the model adapter
         /// </summary>
-        /// <param name="subscription">The subscription the cmdlets are operation under</param>
         /// <returns>The advisor adapter</returns>
-        protected override AzureSqlElasticPoolAdvisorAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override AzureSqlElasticPoolAdvisorAdapter InitModelAdapter()
         {
             return new AzureSqlElasticPoolAdvisorAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/Advisor/Cmdlet/AzureSqlServerAdvisorCmdletBase.cs

@@ -41,9 +41,8 @@ public abstract class AzureSqlServerAdvisorCmdletBase : AzureSqlCmdletBase<IEnum
         /// <summary>
         /// Initializes the model adapter
         /// </summary>
-        /// <param name="subscription">The subscription the cmdlets are operation under</param>
         /// <returns>The advisor adapter</returns>
-        protected override AzureSqlServerAdvisorAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override AzureSqlServerAdvisorAdapter InitModelAdapter()
         {
             return new AzureSqlServerAdvisorAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/Advisor/Service/AzureSqlAdvisorCommunicatorBase.cs

@@ -51,9 +51,9 @@ public class AzureSqlAdvisorCommunicatorBase
         public AzureSqlAdvisorCommunicatorBase(IAzureContext context)
         {
             Context = context;
-            if (context.Subscription != Subscription)
+            if (context?.Subscription != Subscription)
             {
-                Subscription = context.Subscription;
+                Subscription = context?.Subscription;
                 SqlClient = null;
             }
         }

src/Sql/Sql/Auditing/Cmdlet/AuditingSettings/SqlDatabaseAuditingSettingsCmdletBase.cs

@@ -42,9 +42,8 @@ protected override DatabaseBlobAuditingSettingsModel GetEntity()
         /// <summary>
         /// Creation and initialization of the ModelAdapter object
         /// </summary>
-        /// <param name="subscription">The AzureSubscription in which the current execution is performed</param>
         /// <returns>An initialized and ready to use ModelAdapter object</returns>
-        protected override SqlAuditAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override SqlAuditAdapter InitModelAdapter()
         {
             return new SqlAuditAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/Auditing/Cmdlet/AuditingSettings/SqlServerAuditingSettingsCmdletBase.cs

@@ -52,9 +52,8 @@ protected override ServerBlobAuditingSettingsModel GetEntity()
         /// <summary>
         /// Creation and initialization of the ModelAdapter object
         /// </summary>
-        /// <param name="subscription">The AzureSubscription in which the current execution is performed</param>
         /// <returns>An initialized and ready to use ModelAdapter object</returns>
-        protected override SqlAuditAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override SqlAuditAdapter InitModelAdapter()
         {
             return new SqlAuditAdapter(DefaultProfile.DefaultContext);
         }

src/Sql/Sql/Auditing/Cmdlet/SqlDatabaseAuditingCmdletBase.cs

@@ -59,9 +59,8 @@ protected override AuditingPolicyModel GetEntity()
         /// <summary>
         /// Creation and initialization of the ModelAdapter object
         /// </summary>
-        /// <param name="subscription">The AzureSubscription in which the current execution is performed</param>
         /// <returns>An initialized and ready to use ModelAdapter object</returns>
-        protected override SqlAuditAdapter InitModelAdapter(IAzureSubscription subscription)
+        protected override SqlAuditAdapter InitModelAdapter()
         {
             return new SqlAuditAdapter(DefaultProfile.DefaultContext);
         }