SQL Server IaaS Extension cmdlets update

1. Don't print or attempt to print private settings from the Get.
Instead print *** if the options are set.

2. Print a message to educate the user when disabling Azure key vault
that existing credentials will not be removed but AKV status will not be
reported.

3. Update the help file.

4. No new tests are required as the current tests already cover the
changes in this changeset.

Author: OJDUDE

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/GetAzureVMSqlServerExtension.cs

@@ -55,7 +55,7 @@ internal void ExecuteCommand()
 
                     return this.GetExtensionContext(r);
                 }), true);
-        } 
+        }
 
         protected override void ProcessRecord()
         {
@@ -69,7 +69,7 @@ protected override void ProcessRecord()
         /// <returns></returns>
         private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExtensionReference r)
         {
-            string extensionName= VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedNamespace + "."
+            string extensionName = VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedNamespace + "."
                                + VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedName;
 
             VirtualMachineSqlServerExtensionContext context = new VirtualMachineSqlServerExtensionContext
@@ -162,7 +162,7 @@ private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExte
                         NSM.DeploymentSlot.Production);
                 }
                 catch (CloudException e)
-                {  
+                {
                     if (e.Response.StatusCode != HttpStatusCode.NotFound)
                     {
                         throw;
@@ -231,7 +231,11 @@ private AutoBackupSettings DeSerializeAutoBackupSettings(string category, string
                         autoBackupSettings.RetentionPeriod = publicAutoBackupSettings.RetentionPeriod;
                         autoBackupSettings.StorageAccessKey = "***";
                         autoBackupSettings.StorageUrl = "***";
-                        autoBackupSettings.Password = "***";
+
+                        if (autoBackupSettings.EnableEncryption)
+                        {
+                            autoBackupSettings.Password = "***";
+                        }
                     }
                 }
                 catch (JsonReaderException jre)
@@ -246,7 +250,7 @@ private AutoBackupSettings DeSerializeAutoBackupSettings(string category, string
         }
 
         private KeyVaultCredentialSettings DeSerializeKeyVaultCredentialSettings(string category, string input)
-        { 
+        {
             KeyVaultCredentialSettings kvtSettings = new KeyVaultCredentialSettings();
 
             if (!string.IsNullOrEmpty(input))
@@ -256,13 +260,17 @@ private KeyVaultCredentialSettings DeSerializeKeyVaultCredentialSettings(string
                     // we only print the public settings
                     PublicKeyVaultCredentialSettings publicSettings = JsonConvert.DeserializeObject<PublicKeyVaultCredentialSettings>(input);
 
-                    if(publicSettings != null)
+                    if (publicSettings != null)
                     {
                         kvtSettings.CredentialName = publicSettings.CredentialName;
                         kvtSettings.Enable = publicSettings.Enable;
-                        kvtSettings.ServicePrincipalName = "***";
-                        kvtSettings.ServicePrincipalSecret = "***";
-                        kvtSettings.AzureKeyVaultUrl = "***";
+
+                        if (kvtSettings.Enable)
+                        {
+                            kvtSettings.ServicePrincipalName = "***";
+                            kvtSettings.ServicePrincipalSecret = "***";
+                            kvtSettings.AzureKeyVaultUrl = "***";
+                        }
                     }
                 }
                 catch (JsonReaderException jre)

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/SetAzureVMSqlServerExtension.cs

@@ -110,6 +110,12 @@ protected override void ProcessRecord()
         internal void ExecuteCommand()
         {
             ValidateParameters();
+
+            if ((this.KeyVaultCredentialSettings != null) && !this.KeyVaultCredentialSettings.Enable)
+            {
+                WriteVerboseWithTimestamp("SQL Server Azure key vault disabled. Previously configured credentials are not removed but no status will be reported");
+            }
+
             RemovePredicateExtensions();
             AddResourceExtension();
             WriteObject(VM);