fix #13763- webapp:Increased timout to 300000 MS for Publish-AzWebApp cmdlet (#13894)

* fix #13763- Increased timout to 300000 MS for Publish-AzWebApp cmdlet

* Updated changelog.md

* Added optional property for Timeout.

* Added validation for handling minimum Timeout

* Updated changelog

* Addressed review comment

* fixed build issue 'OverflowException'

* Fixed build issue

* Addressed review comments

* Updated Help text for Remove-AzWebAppCertificate

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service (#14128)

* Honoring UseManagedDisk input for HyperV to Azure scenario in site recovery service

* Update in changeLog

* Update in help file

* Minor fix in help file

* Added test cases

* NIT fixes for spaces

* Addressed review comments

* Update ChangeLog.md

Co-authored-by: vidyadharijami <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>

Author: 3 people

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromWar.json

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Introduced an option to give custom timeout for `Publish-AzWebApp` 
 * Added support for App Service Environment
     - `New-AzAppServiceEnvironment`
     - `Remove-AzAppServiceEnvironment`

src/Websites/Websites.Test/SessionRecords/Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests/TestPublishWebAppFromZip.json

@@ -16,6 +16,7 @@
 
 using Microsoft.Azure.Commands.WebApps.Models;
 using Microsoft.Azure.Management.WebSites.Models;
+using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.IO;
 using System.Management.Automation;
@@ -45,6 +46,10 @@ public class PublishAzureWebAppCmdlet : WebAppOptionalSlotBaseCmdlet
         [Parameter(Mandatory = false, HelpMessage = "Run cmdlet in the background")]
         public SwitchParameter AsJob { get; set; }
 
+        [Parameter(Mandatory = false, HelpMessage = "Configurable timeout in millseconds to wait for deployment operation to complete. The default timeout is 100000 milliseconds")]
+        [ValidateRange(100000, 3600000)]
+        public double Timeout { get; set; }
+
         public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
@@ -72,6 +77,12 @@ public override void ExecuteCmdlet()
                 using (var s = File.OpenRead(ArchivePath))
                 {
                     HttpClient client = new HttpClient();
+                    if (this.IsParameterBound(cmdlet => cmdlet.Timeout))
+                    {
+                        // Considering the deployment of large packages the default time(150 seconds) is not sufficient. So increased the timeout based on user choice.
+                        client.Timeout = TimeSpan.FromMilliseconds(Timeout);
+                    }
+
                     var byteArray = Encoding.ASCII.GetBytes(user.PublishingUserName + ":" + user.PublishingPassword);
                     client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Basic", Convert.ToBase64String(byteArray));
                     HttpContent fileContent = new StreamContent(s);

src/Websites/Websites/ChangeLog.md

@@ -64,6 +64,14 @@ PS C:\> Publish-AzWebApp -WebApp $app -ArchivePath C:\project\app.zip -Force
 
 Uploads the contents of java_app.jar to the web app named ContosoApp belonging to the resource group ContosoRG.
 
+### Example 6
+```powershell
+PS C:\> $app = Get-AzWebApp -ResourceGroupName ContosoRG -Name ContosoApp
+PS C:\> Publish-AzWebApp -WebApp $app -ArchivePath C:\project\app.zip -Timeout 300000 -Force
+```
+
+Uploads the contents of java_app.jar to the web app named ContosoApp belonging to the resource group ContosoRG. User can Sets the timespan in Milliseconds to wait before the request times out.
+
 ## PARAMETERS
 
 ### -ArchivePath
@@ -171,6 +179,21 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -Timeout
+Sets the timespan in Milliseconds to wait before the request times out.
+
+```yaml
+Type: System.Double
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -WebApp
 The web app object
 

src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs

@@ -8,7 +8,7 @@ schema: 2.0.0
 # Remove-AzWebAppCertificate
 
 ## SYNOPSIS
-Creates an App service managed certificate for an Azure Web App. 
+Removes an App service managed certificate for an Azure Web App. 
 
 ## SYNTAX
 
@@ -17,7 +17,7 @@ Remove-AzWebAppCertificate [-ResourceGroupName] <String> [-ThumbPrint] <String>
 ```
 
 ## DESCRIPTION
-The **Remove-AzWebAppCertificate** cmdlet creates an Azure App Service Managed Certificate
+The **Remove-AzWebAppCertificate** cmdlet Removes an Azure App Service Managed Certificate
 
 ## EXAMPLES