[Synapse] - Fixed deserialization error when create Pipeline/Dataset/Trigger through DefinitionFile (#13721)

* Remove using Newtonsoft.Json and JsonObject

* update client and cmdlets

* Remove more Newtonsoft annotation

* remove ToSdkObject and SetProperties

* update artifacts client

* Remove JsonProperty

* remove unused sub-classes

* remove internal properties

* Update artifacts dependency version

* Fix the default literal issue

Co-authored-by: Dongwei Wang <[email protected]>

Author: idear1203

src/Synapse/Synapse/Commands/DataPlaneCommands/Artifact/Notebooks/ExportAzureSynapseNotebook.cs

@@ -88,7 +88,7 @@ public override void ExecuteCmdlet()
 
         private void WriteToFile(PSNotebookResource notebook)
         {
-            string json = JsonConvert.SerializeObject(notebook.Properties, Formatting.Indented);
+            string json = Newtonsoft.Json.JsonConvert.SerializeObject(notebook.Properties, Formatting.Indented);
             File.WriteAllText(Path.Combine(this.OutputFolder, notebook.Name + ".ipynb"), json);
         }
     }

src/Synapse/Synapse/Commands/DataPlaneCommands/Artifact/Notebooks/SetAzureSynapseNotebook.cs

@@ -5,7 +5,6 @@
 using Microsoft.Azure.Commands.Synapse.Models;
 using Microsoft.Azure.Commands.Synapse.Properties;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
-using Newtonsoft.Json;
 using System;
 using System.IO;
 using System.Management.Automation;
@@ -80,11 +79,17 @@ public override void ExecuteCmdlet()
                 this.WorkspaceName = this.WorkspaceObject.Name;
             }
 
+            if (!this.IsParameterBound(c => c.Name))
+            {
+                string path = this.TryResolvePath(DefinitionFile);
+                this.Name = Path.GetFileNameWithoutExtension(path);
+            }
+
             if (this.ShouldProcess(this.WorkspaceName, String.Format(Resources.SettingSynapseNotebook, this.Name, this.WorkspaceName)))
             {
                 string rawJsonContent = SynapseAnalyticsClient.ReadJsonFileContent(this.TryResolvePath(DefinitionFile));
-                PSNotebook pSNotebook = JsonConvert.DeserializeObject<PSNotebook>(rawJsonContent);
-                NotebookResource notebookResource = new NotebookResource(pSNotebook.ToSdkObject());
+                Notebook notebook = JsonConvert.DeserializeObject<Notebook>(rawJsonContent);
+                NotebookResource notebookResource = new NotebookResource(this.Name, notebook);
 
                 if (this.IsParameterBound(c => c.SparkPoolName))
                 {
@@ -115,11 +120,6 @@ public override void ExecuteCmdlet()
                     notebookResource.Properties.SessionProperties = new NotebookSessionProperties(options["memory"] + "g", (int)options["cores"], options["memory"] + "g", (int)options["cores"], (int)options["nodeCount"]);
                 }
 
-                if (!this.IsParameterBound(c => c.Name))
-                {
-                    string path = this.TryResolvePath(DefinitionFile);
-                    this.Name = Path.GetFileNameWithoutExtension(path);
-                }
                 WriteObject(new PSNotebookResource(SynapseAnalyticsClient.CreateOrUpdateNotebook(this.Name, notebookResource), this.WorkspaceName));
             }
         }

src/Synapse/Synapse/Commands/DataPlaneCommands/Artifact/PipelineRuns/InvokeAzureSynapsePipeline.cs

@@ -3,12 +3,12 @@
 using Microsoft.Azure.Commands.Synapse.Models;
 using Microsoft.Azure.Commands.Synapse.Properties;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
-using Newtonsoft.Json;
 using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using System.Management.Automation;
+using JsonConvert = Newtonsoft.Json.JsonConvert;
 
 namespace Microsoft.Azure.Commands.Synapse
 {

src/Synapse/Synapse/Common/JsonConvert.cs

@@ -0,0 +1,42 @@
+using System.IO;
+using System.Reflection;
+using System.Text.Json;
+
+namespace Microsoft.Azure.Commands.Synapse.Common
+{
+    internal static class JsonConvert
+    {
+        internal static T DeserializeObject<T>(string rawJsonContent)
+        {
+            var document = JsonDocument.Parse(rawJsonContent);
+            MethodInfo deserializer = typeof(T).GetMethod($"Deserialize{typeof(T).Name}", BindingFlags.NonPublic | BindingFlags.Static);
+            return (T) deserializer.Invoke(null, new object[] { document.RootElement });
+        }
+
+        internal static string SerializeObject(object obj)
+        {
+            // TODO: in future, we might consider to add option to allow users to specify JSON writer options.
+            using (MemoryStream memoryStream = new MemoryStream())
+            using (Utf8JsonWriter writer = new Utf8JsonWriter(memoryStream, new JsonWriterOptions { Indented = true }))
+            {
+                SerializeObject(obj, writer);
+                return memoryStream.ToString();
+            }
+        }
+
+        internal static void SerializeObject(object obj, string outputPath)
+        {
+            using (FileStream writeStream = File.Open(outputPath, FileMode.Create))
+            using (Utf8JsonWriter writer = new Utf8JsonWriter(writeStream))
+            {
+                SerializeObject(obj, writer);
+            }
+        }
+
+        internal static void SerializeObject(object obj, Utf8JsonWriter writer)
+        {
+            MethodInfo serializer = obj.GetType().GetMethod("Write", BindingFlags.NonPublic);
+            serializer.Invoke(obj, new object[] { writer });
+        }
+    }
+}