Skip to content

Commit 39c53f0

Browse files
committed
Suppress credscan (credentials are invalid/for deleted resources)
1 parent c608cd3 commit 39c53f0

File tree

5 files changed

+1520
-1036
lines changed

5 files changed

+1520
-1036
lines changed

src/Resources/Resources.Test/ScenarioTests/DeploymentTests.ps1

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ function Test-NewDeploymentWithQueryString
823823
Set-AzStorageFileContent -ShareName "querystringshare" -Source "sampleLinkedTemplateChild.json" -Path "sampleLinkedTemplateChild.json" -Context $context
824824

825825
#Get SAStoken
826-
$token = New-AzStorageAccountSASToken -Service File -ResourceType Service,Container,Object -Permission "r" -Context $context
826+
$token = New-AzStorageAccountSASToken -Service File -ResourceType Service,Container,Object -Permission "r" -Context $context -ExpiryTime (Get-Date).AddMinutes(2)
827827

828828
#Create deployment
829829
$deployment =New-AzResourceGroupDeployment -Name $rname -ResourceGroupName $rgname -TemplateUri "https://querystringpstests.file.core.windows.net/querystringshare/sampleLinkedTemplateParent.json" -QueryString $token.Substring(1)
@@ -835,6 +835,7 @@ function Test-NewDeploymentWithQueryString
835835
finally
836836
{
837837
# Cleanup
838+
Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $saname;
838839
Clean-ResourceGroup $rgname
839840
}
840841
}
@@ -940,7 +941,7 @@ function Test-WhatIfWithQueryString
940941
Set-AzStorageFileContent -ShareName "querystringshare" -Source "sampleLinkedTemplateChild.json" -Path "sampleLinkedTemplateChild.json" -Context $context
941942

942943
#Get SAStoken
943-
$token = New-AzStorageAccountSASToken -Service File -ResourceType Service,Container,Object -Permission "r" -Context $context
944+
$token = New-AzStorageAccountSASToken -Service File -ResourceType Service,Container,Object -Permission "r" -Context $context -ExpiryTime (Get-Date).AddMinutes(3)
944945

945946
#Create deployment
946947
$deployment =New-AzResourceGroupDeployment -Name $rname -ResourceGroupName $rgname -TemplateUri "https://querystringpstests.file.core.windows.net/querystringshare/sampleLinkedTemplateParent.json" -QueryString $token.Substring(1)
@@ -958,6 +959,7 @@ function Test-WhatIfWithQueryString
958959
finally
959960
{
960961
# Cleanup
962+
Remove-AzStorageAccount -Force -ResourceGroupName $rgname -Name $saname;
961963
Clean-ResourceGroup $rgname
962964
}
963965
}

src/Resources/Resources.Test/ScenarioTests/ResourceTestRunner.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected ResourceTestRunner(ITestOutputHelper output)
4343
.WithExtraRmModules(helper => new[]
4444
{
4545
helper.RMResourceModule,
46-
helper.GetRMModulePath("AzureRM.Monitor.psd1")
46+
helper.GetRMModulePath("AzureRM.Monitor.psd1"),
4747
})
4848
.WithRecordMatcher(
4949
(ignoreResourcesClient, resourceProviders, userAgentsToIgnore) =>

0 commit comments

Comments
 (0)