Fixed dependency injection and review comments

Author: shreyas-gopalakrishna

src/WebJobs.Script/ScriptHostBuilderExtensions.cs

@@ -292,6 +292,10 @@ public static IHostBuilder AddScriptHostCore(this IHostBuilder builder, ScriptAp
 
                 services.AddSingleton<IFileLoggingStatusManager, FileLoggingStatusManager>();
 
+                services.AddSingleton<IWorkerProfileManager, WorkerProfileManager>();
+
+                services.AddSingleton<IWorkerProfileConditionProvider, WorkerProfileConditionProvider>();
+
                 if (!applicationHostOptions.HasParentScope)
                 {
                     AddCommonServices(services);
@@ -336,7 +340,7 @@ public static void AddCommonServices(IServiceCollection services)
             services.AddSingleton<IWorkerProcessFactory, DefaultWorkerProcessFactory>();
             services.AddSingleton<IRpcWorkerProcessFactory, RpcWorkerProcessFactory>();
             services.AddSingleton<IWorkerProfileManager, WorkerProfileManager>();
-            services.AddSingleton<IWorkerProfileConditionProvider, SystemConditionProvider>();
+            services.AddSingleton<IWorkerProfileConditionProvider, WorkerProfileConditionProvider>();
             services.TryAddSingleton<IWebHostRpcWorkerChannelManager, WebHostRpcWorkerChannelManager>();
             services.TryAddSingleton<IDebugManager, DebugManager>();
             services.TryAddSingleton<IDebugStateProvider, DebugStateProvider>();

src/WebJobs.Script/Workers/Profiles/EnvironmentCondition.cs

@@ -9,7 +9,10 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // Environment condition checks if environment variables match the expected output
+    /// <summary>
+    /// An implementation of an <see cref="IWorkerProfileCondition"/> that checks if
+    /// environment variables match the expected output
+    /// </summary>
     public class EnvironmentCondition : IWorkerProfileCondition
     {
         private readonly ILogger _logger;

src/WebJobs.Script/Workers/Profiles/FalseCondition.cs

@@ -3,8 +3,10 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // The false condition always evalues to false.
-    // This condition is used to disable a profile when condition providers fail to resolve conditions.
+    /// <summary>
+    /// An implementation of an <see cref="IWorkerProfileCondition"/> that always evaluates to false.
+    /// This condition is used to disable a profile when condition providers fail to resolve conditions.
+    /// </summary>
     public class FalseCondition : IWorkerProfileCondition
     {
         public bool Evaluate()

src/WebJobs.Script/Workers/Profiles/HostPropertyCondition.cs

@@ -11,7 +11,10 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // HostPropertycondition checks if host match the expected output for properties such as Sku, Platform, HostVersion
+    /// <summary>
+    /// An implementation of an <see cref="IWorkerProfileCondition"/> that checks if different host properties
+    /// such as Sku, Platform, HostVersion match the expected output
+    /// </summary>
     public class HostPropertyCondition : IWorkerProfileCondition
     {
         private readonly ILogger _logger;

src/WebJobs.Script/Workers/Profiles/IWorkerProfileCondition.cs

@@ -3,7 +3,9 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // Interface for different types of conditions
+    /// <summary>
+    /// Interface for different types of profile conditions
+    /// </summary>
     public interface IWorkerProfileCondition
     {
         /// <summary>

src/WebJobs.Script/Workers/Profiles/IWorkerProfileConditionProvider.cs

@@ -3,7 +3,9 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers.Profiles
 {
-    // Manage differnt conditions
+    /// <summary>
+    /// Interface to manage different profile condition providers
+    /// </summary>
     internal interface IWorkerProfileConditionProvider
     {
         /// <summary>

src/WebJobs.Script/Workers/Profiles/IWorkerProfileManager.cs

@@ -7,7 +7,9 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // Regulate profile operations through the profile manager
+    /// <summary>
+    /// Interface to regulate profile operations through the profile manager
+    /// </summary>
     public interface IWorkerProfileManager
     {
         /// <summary>

src/WebJobs.Script/Workers/Profiles/WorkerDescriptionProfile.cs

@@ -8,6 +8,9 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
+    /// <summary>
+    /// Class that holds data of a profile
+    /// </summary>
     public class WorkerDescriptionProfile
     {
         public WorkerDescriptionProfile(string name, List<IWorkerProfileCondition> conditions, RpcWorkerDescription profileDescription)

src/WebJobs.Script/Workers/Profiles/SystemConditionProvider.cs renamed to src/WebJobs.Script/Workers/Profiles/WorkerProfileConditionProvider.cs

@@ -7,17 +7,17 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    internal sealed class SystemConditionProvider : IWorkerProfileConditionProvider
+    internal sealed class WorkerProfileConditionProvider : IWorkerProfileConditionProvider
     {
-        private readonly ILogger _logger;
+        private readonly ILogger<WorkerProfileConditionProvider> _logger;
         private readonly IEnvironment _environment;
         private readonly ISystemRuntimeInformation _systemRuntimeInformation;
 
-        public SystemConditionProvider(ILogger logger, ISystemRuntimeInformation systemRuntimeInfo, IEnvironment environment)
+        public WorkerProfileConditionProvider(ILogger<WorkerProfileConditionProvider> logger, ISystemRuntimeInformation systemRuntimeInfo, IEnvironment environment)
         {
             _logger = logger ?? throw new ArgumentNullException(nameof(logger));
             _environment = environment ?? throw new ArgumentNullException(nameof(environment));
-            _systemRuntimeInformation = systemRuntimeInfo ?? throw new ArgumentNullException(nameof(systemRuntimeInfo));
+            _systemRuntimeInformation = systemRuntimeInfo ?? SystemRuntimeInformation.Instance;
         }
 
         /// <inheritdoc />

src/WebJobs.Script/Workers/Profiles/WorkerProfileManager.cs

@@ -9,18 +9,21 @@
 
 namespace Microsoft.Azure.WebJobs.Script.Workers
 {
-    // The default profile manager that manages profiles from language workers
+    /// <summary>
+    /// The default profile manager that manages profiles from language workers
+    /// </summary>
     internal class WorkerProfileManager : IWorkerProfileManager
     {
         private readonly ILogger _logger;
         private readonly IEnumerable<IWorkerProfileConditionProvider> _conditionProviders;
-        private Dictionary<string, List<WorkerDescriptionProfile>> _profiles = new Dictionary<string, List<WorkerDescriptionProfile>>();
+        private Dictionary<string, List<WorkerDescriptionProfile>> _profiles;
         private string _activeProfile;
 
-        public WorkerProfileManager(ILogger logger, IEnumerable<IWorkerProfileConditionProvider> conditionProviders)
+        public WorkerProfileManager(ILogger<WorkerProfileManager> logger, IEnumerable<IWorkerProfileConditionProvider> conditionProviders)
         {
             _logger = logger ?? throw new ArgumentNullException(nameof(logger));
             _conditionProviders = conditionProviders ?? throw new ArgumentNullException(nameof(conditionProviders));
+            _profiles = new Dictionary<string, List<WorkerDescriptionProfile>>();
             _activeProfile = string.Empty;
         }