Refactor "shim" file into modules #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Jul 22, 2023
hossam-nasr
force-pushed
the
hossamnasr/engineering
branch
2 times, most recently
from
022453c to
6470a4f
Compare
ejizba
approved these changes
Jul 24, 2023
hossam-nasr
force-pushed
the
hossamnasr/engineering
branch
from
b205c55 to
1f2be7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Azure/azure-functions-nodejs-library#50 on the node library. This PR doesn't make any code or functionality changes, just reorganizes code. It removes the use of namespaces, and gets rid of the "shim.ts" file in favor of exporting modules for each "namespace"