ci: mtu check for cilium e2e #3624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an MTU check for Cilium e2e tests by deploying an nginx application and executing a validation script to compare pod and node MTU values.
- Adds a new nginx deployment manifest for Kubernetes
- Integrates MTU validation steps into multiple pipeline YAML templates
- Executes the cilium-mtu-validation.sh script via newly added CI steps
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/manifests/nginx.yaml | New nginx deployment manifest for MTU testing deployed in kube-system |
| .pipelines/templates/cilium-tests.yaml | Added CI step to deploy nginx and run MTU validation |
| .pipelines/singletenancy/cilium/cilium-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
| .pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
| .pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml | Added CI step for MTU validation |
| .pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
| .pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml | Added CI step for MTU validation |
| .pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e.steps.yaml | Added CI step with workingDirectory for MTU validation |
| .pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e-step-template.yaml | Added CI step for MTU validation |
| .pipelines/cni/cilium/cilium-overlay-load-test-template.yaml | Extended load test with MTU validation steps |
Files not reviewed (1)
- hack/scripts/cilium-mtu-validation.sh: Language not supported
jpayne3506
requested changes
May 5, 2025
vipul-21
requested changes
May 8, 2025
Comment on lines
4
to
5
| kubectl apply -f hack/manifests/nginx.yaml | ||
| kubectl wait --for=condition=available --timeout=60s -n kube-system deployment/nginx |
There was a problem hiding this comment.
we are doing this in the script as well right ? We can remove tis from here in that case.
| # in CNI release test scenario scale deployments to 3 * node count to get replicas on each node | ||
| if [ "$node_count" -gt 1 ]; then | ||
| echo "Scaling nginx deployment to $((3 * node_count)) replicas" | ||
| kubectl scale deployment nginx --replicas=$((2 * node_count)) -n kube-system |
There was a problem hiding this comment.
So it says scaing to 3*node_count but does only to 2*node_count ?
There was a problem hiding this comment.
ah will update this, meant to be 3
There was a problem hiding this comment.
Wouldn't this be easier to just set this on line 8 and just call $(node_count)?
jpayne3506
reviewed
May 8, 2025
.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml
Outdated
Show resolved
Hide resolved
| # in CNI release test scenario scale deployments to 3 * node count to get replicas on each node | ||
| if [ "$node_count" -gt 1 ]; then | ||
| echo "Scaling nginx deployment to $((3 * node_count)) replicas" | ||
| kubectl scale deployment nginx --replicas=$((2 * node_count)) -n kube-system |
There was a problem hiding this comment.
Wouldn't this be easier to just set this on line 8 and just call $(node_count)?
jpayne3506
requested changes
May 9, 2025
.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml
Outdated
Show resolved
Hide resolved
.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e.steps.yaml
Outdated
Show resolved
Hide resolved
jpayne3506
previously approved these changes
May 15, 2025
vipul-21
reviewed
May 15, 2025
| echo "Nginx pod eth0 MTU: $nginx_mtu" | ||
|
|
||
| # Get the node's eth0 MTU | ||
| node_mtu=$(kubectl debug node/$node -it --image=busybox -- sh -c "cat /sys/class/net/eth0/mtu" 2>/dev/null | tail -n 1) |
There was a problem hiding this comment.
Any reason why we need to tail this and not the other one ?
There was a problem hiding this comment.
there's some extra output from creating the debug pod that needs to be filtered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
compare pod eth0 mtu with node eth0 mtu and verify same value
Issue Fixed:
Requirements:
Notes: