Skip to content

Commit c49a676

Browse files
authored
Remove external dependencies from coverage, increase default target (#245)
* Remove external dependencies from coverage * Retry path specification * Update ci.yml Reviewing what happens with dependencies * Update codecov.yml Experimenting * Including contributing.md * Trying exclusion per docs * Trying this another way
1 parent 96f6359 commit c49a676

File tree

3 files changed

+47
-13
lines changed

3 files changed

+47
-13
lines changed

.github/codecov.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,17 @@ comment:
44
require_changes: false
55
github_checks:
66
annotations: false
7+
ignore:
8+
- "**/distro.py"
9+
- "src/external_dependencies"
710
coverage:
811
precision: 2
912
round: down
1013
range: "70...100"
1114
status:
1215
project:
1316
default:
14-
target: 75%
17+
target: 90%
1518
threshold: 0%
1619
if_ci_failed: error
1720
if_not_found: failure
@@ -26,4 +29,4 @@ coverage:
2629
target: 100%
2730
threshold: 0%
2831
if_ci_failed: error
29-
if_not_found: failure
32+
if_not_found: failure

CONTRIBUTING.md

Lines changed: 39 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ If you would like to become an active contributor to this project, please follow
1212
[Making Changes](#making-changes)
1313
- [Pull Requests](#pull-requests)
1414
- [Pull Request Guidelines](#pull-request-guidelines)
15+
- [PR Planning / AzGPS Engineering Requirements](#pr-planning--azgps-engineering-requirements)
1516
- [Cleaning up commits](#cleaning-up-commits)
1617
- [General guidelines](#general-guidelines)
1718
- [Testing guidelines](#testing-guidelines)
@@ -41,6 +42,12 @@ To open your own pull request, click [here](https://github.com/Azure/LinuxPatchE
4142

4243
### Pull Request Guidelines
4344

45+
#### PR Planning / AzGPS Engineering Requirements
46+
47+
The backlog for the Linux Patch Extension is tracked internally at Microsoft (by the Azure Guest Patching Service team in the Azure Core Compute Platform). There are also closed-source dependencies with the Compute Platform on this extension, and there are internal quality-control requirements set on end-to-end scenarios.
48+
49+
To ensure smooth engineering, if there's a change required on the extension, please proactively start a conversation with the engineering team via the Issues page. We cannot provide an SLA on unsolicited PRs if not discussed prior, so please reach out as early as possible.
50+
4451
#### Cleaning up Commits
4552

4653
If you are thinking about making a large change, **break up the change into small, logical, testable chunks, and organize your pull requests accordingly**.
@@ -51,28 +58,49 @@ If you find yourself creating a pull request and are unable to see all the chang
5158

5259
If splitting up the pull request is not an option, we recommend **creating individual commits for different parts of the pull request, which can be reviewed individually on GitHub**.
5360

54-
For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](https://github.com/Azure/azure-powershell/blob/dev/documentation/development-docs/cleaning-up-commits.md).
61+
For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/cleaning-up-commits.md).
5562

5663
#### General guidelines
5764

5865
The following guidelines must be followed in **EVERY** pull request that is opened.
5966

60-
- Title of the pull request is clear and informative
61-
- There are a small number of commits that each have an informative message
62-
- A description of the changes the pull request makes is included, and a reference to the issue being resolved, if the change address any
63-
- All files have the Microsoft copyright header
67+
- Title of the pull request is clear and informative.
68+
- There are a small number of commits that each have an informative message.
69+
- A description of the changes the pull request makes is included, and a reference to the issue being resolved, if the change address any.
70+
- All files have the Microsoft copyright header.
6471

6572
#### Testing Guidelines
6673

6774
The following guidelines must be followed in **EVERY** pull request that is opened.
6875

6976
- Pull request includes test coverage for the included changes
70-
- All existing tests must continue to pass successfully on both Python 2.7+ and Python 3.x.
71-
- Code must have been tested on all supported distributions and versions of those distributions that have not reached end of life. The distribution test matrix is as follows:
77+
- All new code introduced **must not** reduce the measured code coverage of any file or of the master branch as a whole.
78+
- Code coverage threshold to be met: **95% on all new code.** Efforts are ongoing to meet or exceed this target on existing code.
79+
- All existing tests must continue to pass successfully on both Python 2.7+ and Python 3.x (latest version).
80+
- Code must have been tested on all supported distributions and versions of those distributions that have not reached end of life. The primary distribution test matrix is as follows:
7281

7382
Dist | Version |
7483
-----|---------|
75-
Ubuntu Server | 16.04-LTS, 18.04-LTS, 20.04-LTS
76-
Red Hat Enterprise Linux | 6 (x86/x64), 7 (x64), 8 (x64)
77-
CentOS | 6 (x86/x64), 7 (x64), 8 (x64)
78-
SUSE Linux Enterprise Server | 11 (x86/x64), 12 (x64), 15 (x64)
84+
Ubuntu Server | 20.04-LTS, 22.04-LTS, 24.04-LTS
85+
Red Hat Enterprise Linux | 8 (x64), 9 (x64)
86+
SUSE Linux Enterprise Server | 15 (x64)
87+
88+
The following distribution-versions are supported under **extended support policies** from the vendor and **must also be tested**:
89+
90+
Dist | Version | Comment |
91+
-----|---------|---------|
92+
Ubuntu Server | 16.04-LTS, 18.04-LTS | Until Apr 2nd, 2026 & Apr 1st, 2028 (resp.)
93+
Red Hat Enterprise Linux | 7 (x64) | Until Jun 30th, 2024
94+
CentOS | 7 (x64) | Until Jun 30th, 2024
95+
SUSE Linux Enterprise Server | 12 (x64) | Until Oct 31st, 2027
96+
97+
The following distributions have been **EXCLUDED** from support due to end of life and end of extended support:
98+
99+
Dist | Version | Comment |
100+
-----|---------|---------|
101+
Red Hat Enterprise Linux | 6 (x86/x64) | Ended Nov 30th, 2020
102+
CentOS | 6 (x86/x64), 8 (x64) | Ended Nov 30th, 2020 & Dec 31st, 2021 (resp.)
103+
SUSE Linux Enterprise Server | 11 (x86/x64) | Ended Mar 31st, 2022
104+
105+
**All dates listed are accurate as of March 12th, 2024. Please refer to official distribution vendor guidance for up-to-date information.**
106+

codecov.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
ignore:
2+
- "**/distro.py"
3+
- "src/external_dependencies"

0 commit comments

Comments
 (0)