Skip to content

Conversation

@valentingregoire
Copy link
Contributor

📑 Description

Added keybindings for the diff command. This is now accessible via the <Leader>D submenu.

ℹ Additional Information

image

Signed-off-by: Valentin Grégoire <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter
Copy link
Member

This should probably go in recipes since this isn't adding a plugin.

@valentingregoire
Copy link
Contributor Author

This should probably go in recipes since this isn't adding a plugin.

Probably or definitely?

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor this to use astroui for the icon.

@Uzaaft
Copy link
Member

Uzaaft commented Aug 29, 2025

This should probably go in recipes since this isn't adding a plugin.

Probably or definitely?

100% recipes makes more sense.

@valentingregoire
Copy link
Contributor Author

This should probably go in recipes since this isn't adding a plugin.

Probably or definitely?

100% recipes makes more sense.

Will make the changes one of the following days 👍.

@Uzaaft Uzaaft changed the title feat(keybinding): add keybindings feat(pack): add keybindings to diff command Sep 19, 2025
@Uzaaft Uzaaft changed the title feat(pack): add keybindings to diff command feat(pack): add pack for keybindings to diff command Sep 23, 2025
@Uzaaft Uzaaft merged commit 05ecb92 into AstroNvim:main Sep 23, 2025
20 checks passed
@boydaihungst
Copy link
Contributor

image There are 2 spaces after the icon.

@Uzaaft
Copy link
Member

Uzaaft commented Sep 27, 2025

image There are 2 spaces after the icon.

A PR would have been more helpful.

@boydaihungst

This comment was marked as abuse.

@valentingregoire
Copy link
Contributor Author

Thanks, people!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants