Skip to content

Conversation

@std-enigma
Copy link
Contributor

@std-enigma std-enigma commented Aug 26, 2025

Closes #1629

@github-actions
Copy link

github-actions bot commented Aug 26, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@std-enigma std-enigma changed the title fix(hop): visual-selection related keymapping bug fix(hop-nvim): visual-selection related keymapping bug Aug 26, 2025
@Uzaaft
Copy link
Member

Uzaaft commented Aug 27, 2025

What issue does this solve? Why is it problematic to have this for visual and select mode

@Uzaaft
Copy link
Member

Uzaaft commented Aug 27, 2025

Ah this closes #1629.
Please use the template next time @std-enigma . Not all fields needs to be filled

@Uzaaft Uzaaft merged commit cbb7302 into AstroNvim:main Aug 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch Hop.nvim visual mode keymaps from v to x to prevent snippet/selection conflicts

2 participants