Skip to content

Conversation

@Mega31
Copy link
Contributor

@Mega31 Mega31 commented Jun 15, 2025

📑 Description

  • the golang adapter for neotest is outdated and does not even supports proper table driven testing(output is really messy)
  • Adapter written by fredrikaverpil is much better and has many features which community would love https://fredrikaverpil.github.io/neotest-golang/

@github-actions
Copy link

github-actions bot commented Jun 15, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov
Copy link
Contributor

azdanov commented Jun 15, 2025

nvim-neotest/neotest-go#52 (comment)
Yeah, neotest-go doesn't have much resources to be updated.

PR title needs changing, since it's a breaking change and needs to mention which pack. Probably it's even a feature, since it might offer different functionality.

@Mega31
Copy link
Contributor Author

Mega31 commented Jun 15, 2025

nvim-neotest/neotest-go#52 (comment) Yeah, neotest-go doesn't have much resources to be updated.

PR title needs changing, since it's a breaking change and needs to mention which pack. Probably it's even a feature, since it might offer different functionality.

How is that a breaking change? I mean it just works

and I don't think it's a feature too, it simply extends functionality and makes overall things better?

@Mega31
Copy link
Contributor Author

Mega31 commented Jun 15, 2025

nvim-neotest/neotest-go#52 (comment) Yeah, neotest-go doesn't have much resources to be updated.
PR title needs changing, since it's a breaking change and needs to mention which pack. Probably it's even a feature, since it might offer different functionality.

How is that a breaking change? I mean it just works

and I don't think it's a feature too, it simply extends functionality and makes overall things better?

nvm it is a feature from astronvim pov. I have updated commit message now, hope it's okay

with fredrikaverpil adapter, as it's more maintained and has more features
@Mega31 Mega31 force-pushed the update/use-maintained-verision-of-neotest-adapter-in-golang branch from e7c3f88 to ac34242 Compare June 15, 2025 14:39
@Mega31 Mega31 changed the title chore(pack): replaced nvim-neotest golang adapter with fredrikaverpil adapter, as it's more maintained and has more features feat(pack.go): replaced nvim-neotest golang adapter with fredrikaverpil adapter, as it's more maintained and has more features Jun 15, 2025
@Uzaaft
Copy link
Member

Uzaaft commented Jun 15, 2025

@Mega31 PR title is still incorrect. Fixed it.

@Uzaaft Uzaaft changed the title feat(pack.go): replaced nvim-neotest golang adapter with fredrikaverpil adapter, as it's more maintained and has more features feat(go): replace nvim-neotest/neotest-go with fredrikaverpil/neotest-go Jun 15, 2025
@Uzaaft
Copy link
Member

Uzaaft commented Jun 15, 2025

@Mega31 Wanna give it a last test run before we merge this in?

@Mega31
Copy link
Contributor Author

Mega31 commented Jun 15, 2025

@Mega31 Wanna give it a last test run before we merge this in?

yep

@Mega31
Copy link
Contributor Author

Mega31 commented Jun 15, 2025

@Uzaaft just tested out. works fine

@azdanov azdanov changed the title feat(go): replace nvim-neotest/neotest-go with fredrikaverpil/neotest-go feat(go): replace nvim-neotest/neotest-go with fredrikaverpil/neotest-golang Jun 16, 2025
Copy link
Contributor

@azdanov azdanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Uzaaft Uzaaft merged commit 656c66f into AstroNvim:main Jun 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants