Skip to content

Conversation

@azdanov
Copy link
Contributor

@azdanov azdanov commented May 31, 2025

Closes #1131

📑 Description

This should fix the issue, and also these root_dir are mentioned in the nvim-jdtls readme. My previous PR was not correct, since it was for lspconfig: #1525 and not nvim-jdtls.

ℹ Additional Information

@github-actions
Copy link

github-actions bot commented May 31, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov azdanov requested a review from a team June 1, 2025 03:29
@Uzaaft Uzaaft merged commit 2107a4c into main Jun 1, 2025
21 checks passed
@Uzaaft Uzaaft deleted the azdanov-patch-2 branch June 1, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java pack root_dir

3 participants