Skip to content

Conversation

@azdanov
Copy link
Contributor

@azdanov azdanov commented May 28, 2025

📑 Description

Added missing root markers.

ℹ Additional Information

https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/configs/jdtls.lua#L90

Is there some way to reference the default root markers from lspconfig? Would be good to avoid duplication.

@github-actions
Copy link

github-actions bot commented May 28, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov azdanov changed the title chore(java): update root markers fix(java): update root markers May 28, 2025
@azdanov azdanov requested a review from Copilot May 29, 2025 03:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the root marker list used for determining the project root directory for Java projects.

  • Replaces the old marker list with a new list that adds support for additional Gradle and Maven configuration files.
  • Removes some previously supported markers, possibly unintentionally.
Comments suppressed due to low confidence (1)

lua/astrocommunity/pack/java/init.lua:52

  • The new root marker list removes markers such as 'mvnw', 'gradlew' and '.project', which were present in the old version. Verify if their removal is intentional, as this could affect project root detection for projects using Maven or Gradle wrappers.
local root_markers = {

@Uzaaft Uzaaft merged commit 62865ef into AstroNvim:main May 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants