Skip to content

Conversation

@azdanov
Copy link
Contributor

@azdanov azdanov commented May 17, 2025

Issue: #1501

📑 Description

Adds ESLint based on the typescript pack. Needs testing and maybe potentially adding eslint.d support to replace EslintFixAll autocmd.

ℹ Additional Information

See #1496 for discussion on EslintFixAll

@github-actions
Copy link

github-actions bot commented May 17, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@azdanov azdanov marked this pull request as ready for review May 18, 2025 04:53
@azdanov

This comment was marked as outdated.

@azdanov azdanov requested review from a team and Copilot May 20, 2025 02:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds ESLint integration to the Astro Neovim community pack by ensuring the ESLint LSP and tooling are installed and showing ESLint config files in MiniIcons.

  • Ensures eslint server and eslint-lsp tool are installed via Mason
  • Adds file icons for various .eslintrc* and eslint.config.* files in mini.icons
  • Provides a README with prerequisites

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
lua/astrocommunity/pack/eslint/init.lua Configures Mason to install ESLint LSP and tooling, and adds file icons for ESLint configs
lua/astrocommunity/pack/eslint/README.md Adds basic README with ESLint description and prerequisites

@Uzaaft Uzaaft merged commit 8ae3804 into AstroNvim:main Jun 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants