-
-
Notifications
You must be signed in to change notification settings - Fork 305
feat(pack): add eslint #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): add eslint #1503
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds ESLint integration to the Astro Neovim community pack by ensuring the ESLint LSP and tooling are installed and showing ESLint config files in MiniIcons.
- Ensures
eslintserver andeslint-lsptool are installed via Mason - Adds file icons for various
.eslintrc*andeslint.config.*files inmini.icons - Provides a README with prerequisites
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lua/astrocommunity/pack/eslint/init.lua | Configures Mason to install ESLint LSP and tooling, and adds file icons for ESLint configs |
| lua/astrocommunity/pack/eslint/README.md | Adds basic README with ESLint description and prerequisites |
Co-authored-by: Uzair Aftab <[email protected]>
Issue: #1501
📑 Description
Adds ESLint based on the typescript pack. Needs testing and maybe potentially adding
eslint.dsupport to replaceEslintFixAllautocmd.ℹ Additional Information
See #1496 for discussion on EslintFixAll