Skip to content

Tokenize hexadecimal string sequences + minor enhancements #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2019
Merged

Tokenize hexadecimal string sequences + minor enhancements #970

merged 4 commits into from
Nov 23, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Nov 22, 2019

Allow "\xFD\x7F" sequences for string literals

@MaxGraey
Copy link
Member Author

MaxGraey commented Nov 22, 2019

JavaScript also support octal sequences but its not recommended so not sure we should implement it

@MaxGraey MaxGraey requested a review from dcodeIO November 22, 2019 22:13
@MaxGraey MaxGraey changed the title Tokenize hexadecimal string sequences Tokenize hexadecimal string sequences + minor enhancements Nov 23, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Nov 23, 2019

LGTM :)

@MaxGraey MaxGraey requested a review from dcodeIO November 23, 2019 10:35
@dcodeIO dcodeIO merged commit 2a83652 into AssemblyScript:master Nov 23, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Nov 23, 2019

Great, thanks!

@MaxGraey MaxGraey deleted the add-hexadecimal-sequences branch November 23, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants