Support anyref variable declartions as Wasm locals

[jayphelps]

declare function external(a: anyref): anyref;

export function internal(a: anyref): anyref {
  // is an anyref
  const b = external(a);
  return b;
}

Right now if you try to use an anyref as a variable declaration it barfs with:

ERROR: concrete type expected
    at c.getTempLocal

This solves it by making the compiler aware that anyrefs can be stored as locals

Keywords: reference types, reference-types, gc

[MaxGraey]

It seems this same issue with public email: #863

[jayphelps]

@MaxGraey it looks OK now I think. But one of them is failing because I forgot to update the snapshots I think and I didn't notice that by default it doesn't run the tests with that features/reference-types enabled so I thought the tests were all passing but they were just skipped. I'm not sure how to enable it, but I'm looking.

[jayphelps]

Ok figured out how to run it enabled:

ASC_FEATURES=reference-types npm run test:compiler rt/flags "features/reference-types"

Fixing the snapshots now.

[jayphelps]

All green. 🎉

[dcodeIO]

Nice find! For a bit of background: It worked for var since these become distinct locals, but not for const and let because those obtain shared locals (a temp for the lifetime of their scope).

[jayphelps]

@dcodeIO

Made the NOTICE file change.

Nice find! For a bit of background: It worked for var since these become distinct locals, but not for const and let because those obtain shared locals (a temp for the lifetime of their scope).

Great to know! With that in mind, I modified the test to use all three: const, let, var so it hits those code paths.

[dcodeIO]

Perfect, thanks! :)