Skip to content

Test pika-ci #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Test pika-ci #956

wants to merge 4 commits into from

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Nov 14, 2019

This is a PR to test pika-ci as mentioned in #951

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 14, 2019

The initial commit won't work ofc because they run npm run build on their servers, which doesn't switch out index.js. More of a test run.

What we could ultimately do is to flip index.js on npm run build and reverse it on npm run clean again.

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 14, 2019

What we could ultimately do is to flip index.js on npm run build and reverse it on npm run clean again.

Actually, we'll most likely run into problems this way since the repo will end up with various files that should not be committed, leading to an endless story of telling everyone why their PR failed. Quite similar to what we had with dist files before.

Perhaps if there is a way to detect that the build is running inside of pika-ci we'd be able to run additional stuff on npm run build, but it's hard to tell whether something like that is supported since there are no docs whatsoever covering topics like this.

In general it seems that just running npm run build interferes with our new release magic in unfortunate ways, and a more fine-grained approach would be preferable.

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 15, 2019

Hmm, unfortunately pika doesn't appear to run prepublish as well :(

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 15, 2019

As an alternative we could make our own little pika-like thing by publishing PRs as [email protected] or something. However, that might yield a quadrillion of packages being published over the course of several PRs with multiple commits to it, so I'm not sure that npm would be too keen about it.

@MaxGraey
Copy link
Member

Hmm, probably @FredKSchott suggest something...

@enjoythelive1
Copy link

Hmm, unfortunately pika doesn't appear to run prepublish as well :(

the prepublishOnlyscript only run when npm publish is executed. Maybe use prepare instead. It runs at the same time as prepublish use to.

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 15, 2019

Thanks for the hint, but sadly:

prepare: Run both BEFORE the package is packed and published, on local npm install without any arguments, and when installing git dependencies (See below). This is run AFTER prepublish, but BEFORE prepublishOnly.

Both on local npm install and when installing git dependencies would break things.

@dcodeIO
Copy link
Member Author

dcodeIO commented Nov 18, 2019

This PR is empty now because I merged generally useful changes to master in #964.

@dcodeIO dcodeIO closed this Jan 10, 2020
@dcodeIO dcodeIO deleted the pika-test branch March 15, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants