-
-
Notifications
You must be signed in to change notification settings - Fork 670
ARC optimizations #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ARC optimizations #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
reviewed
Oct 26, 2019
Alright, last commit uses a custom Binaryen build with the PostAssemblyScript stuff I came up with so far. Also copies Binaryen's pass order instead of inheriting |
MaxGraey
reviewed
Oct 27, 2019
Interesting cases for further inspection Size reduced
Size increased
|
Merged
MaxGraey
reviewed
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to perform ARC optimizations with a PostAssemblyScript Binaryen pass, this PR adds better hints for the optimizer to determine (and then follow) a
__retain
. Reason is that previously the compiler would emit code likewhen just retaining something that already exists, like a function argument that magically exists but isn't set explicitly, but without a
local.set
we cannot follow the influences of the retain through the local graph.With the change the compiler emits
so we can easily see that the local
$0
is retained from here onward but wasn't before, and anylocal.get
influenced by thelocal.set
is safe to assume to inherit the retain.This was especially problematic with flattening, leading to code like
which completely misses the side effect if we start at
local.set $2
that is never used again.Interestingly, this moves quite some code around in our test fixtures as well, even though its functionally the same.