-
-
Notifications
You must be signed in to change notification settings - Fork 669
[Implement] Lots of useful Builtins #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Continuing after #735 (comment) Going with our own naming scheme and aliasing those types TS has as well sounds good. So, when we go down that route, the uppercase namings would be aliases while our naming scheme would be all lower case to match what we have already (e.g.
so there's no arbitrary mixing in the original implementations, with just the aliases deviating. |
|
@MaxGraey I would love to figure out how to implement @dcodeIO I disagree with I doctored the EventEmitter pull request to showcase how they might be used here: https://github.com/assemblyscript/node Check out the pull request and use this as context. I'll also get around to implementing the aliases soon. Thanks for the input. |
@dcodeIO Should be good now for Please help me clean up this pull request and get it sorted soon! Thanks. |
Can you help me enumerate the rest of the aliases too? I'm pretty sure I'm missing a few. |
Alright. I've tried my best to cover the latest round of nitpicks. Anything else? |
@dcodeIO A few people I talked to might like a |
Seems Regarding ref/deref: I remember vaguely that I had been thinking about different names when introducing |
Thanks! :) |
Keep in mind that the dist files need to be updated before the builtins can be used. |
Instead of a bunch of tiny builtin requests, I decided this was a nice subset of the proposed ones to merge immediately pending review. I'm sure there's lots of little things we could make better, but it's my intention to get this done by the end of the week so I can get back to work on
EventEmitter
.Features:
isVoid<T>()
ParameterCount<T>(func?: T): i32
lengthof<T extends Function>(func?: T)
nameof<T>(value?: T): string
idof<T>(): i32
ReturnType<T>
Signature#equals(value: Signature): bool